“Current page” radio button is enabled on the system dialog for every webpage
Categories
(Core :: Printing: Setup, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox83 | --- | unaffected |
| firefox84 | --- | verified |
| firefox85 | --- | verified |
People
(Reporter: emilghitta, Assigned: emilio)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression, Whiteboard: [print2020_v84][old-ui+])
Attachments
(2 files)
|
16.57 KB,
image/png
|
Details | |
|
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
CurrentPage.png
Affected versions
- Firefox 84.0b4 (BuildId:20201122152513)
- Firefox 85.0a1 (BuildId:20201123095316)
Affected platforms
- Windows 10 64bit
Unaffected platforms
- macOS 10.14
- Ubuntu 20.04 64bit
Steps to reproduce
- Launch Firefox.
- Access any random webpage.
- Hit CTRL + P.
- Click on the “Print using the system dialog option”
Expected result
- The “Current Page” radio button is disabled.
Actual result
- The “Current Page” radio button is enabled. Selecting the "Current Page" option and clicking print has the same output as the "All" radio button option.
Regression Range
- This seems to be a regression:
- Possible regressor: Bug 1675956
Notes
- For further information please observe the attached screenshot.
- [Suggested Severity] I think that S3 fits for this issue.
|
Reporter | |
Comment 1•4 years ago
|
||
Hi Emilio!
Can you please take a look?
Thank you!
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 2•4 years ago
|
||
This was accidentally enabled when moving to the more modern print dialog API.
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cb700708fe36 Disable "Current Page" checkbox in the Windows print dialog. r=bobowen
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
|
||
Comment 5•3 years ago
|
||
The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.
For more information, please visit auto_nag documentation.
|
|
Assignee | |
Comment 6•3 years ago
|
||
Comment on attachment 9189649 [details]
Bug 1679156 - Disable "Current Page" checkbox in the Windows print dialog. r=jfkthame,bobowen
Beta/Release Uplift Approval Request
- User impact if declined: current page option appears and is ignored in the windows print dialog.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: comment 0
- List of other uplifts needed: none
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Simple flag to disable the checkbox and fix the regression.
- String changes made/needed: none
|
|
Assignee | |
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
|
||
Comment 7•3 years ago
|
||
Comment on attachment 9189649 [details]
Bug 1679156 - Disable "Current Page" checkbox in the Windows print dialog. r=jfkthame,bobowen
Approved for 84.0b7.
|
|
||
Comment 8•3 years ago
|
||
| bugherder uplift | ||
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
||
Comment 9•3 years ago
|
||
Hello,
Reproduced this issue with a mozregression build from 2020-11-24.
Confirming this issue as verified fixed on 84.0b7(20201201213706)and 85.0a1(20201202091636) and on Win10x64, Win10x64aarch, Win7x64.
Description
•