Closed
Bug 1678611
Opened 4 years ago
Closed 3 years ago
Replace onTitleChanged with a page-title-changed PlacesEvent
Categories
(Toolkit :: Places, task, P3)
Toolkit
Places
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox86 | --- | fixed |
People
(Reporter: mak, Assigned: daisuke)
References
Details
Attachments
(4 files)
In the future it would be great if the title of a page could only be changed by adding a visit (and then page-visited would be enough for it), but for now the DocShell is sending separate notifications for visit addition and title change.
Thus temporarily we can introduce a page-title-changed event, so we can remove onTitleChanged.
|
Assignee | |
Updated•4 years ago
|
Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Iteration: --- → 85.2 - Nov 30 - Dec 13
Points: --- → 3
|
|
Assignee | |
Updated•4 years ago
|
Points: 3 → 5
|
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
Depends on D98278
|
|
Assignee | |
Comment 3•4 years ago
|
||
Depends on D98280
|
||
Updated•3 years ago
|
Attachment #9190444 -
Attachment description: Bug 1678611: Imlement a mechanism to fire page-title-changed event. → Bug 1678611: Implement a mechanism to fire page-title-changed event.
|
|
Assignee | |
Comment 4•3 years ago
|
||
Depends on D98281
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/537d90684581 Implement a mechanism to fire page-title-changed event. r=mak https://hg.mozilla.org/integration/autoland/rev/942167393237 Apply page-title-changed event instead of onTitleChanged. r=mak,mixedpuppy https://hg.mozilla.org/integration/autoland/rev/6498a49aab45 Remove onTitleChanged interface from nsINavHistoryService. r=mak,mixedpuppy https://hg.mozilla.org/integration/autoland/rev/01e15bba25d4 Add a test for multi observation. r=mak
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/537d90684581
https://hg.mozilla.org/mozilla-central/rev/942167393237
https://hg.mozilla.org/mozilla-central/rev/6498a49aab45
https://hg.mozilla.org/mozilla-central/rev/01e15bba25d4
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox86:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•