Suggested severity

• S2

Affected versions

• Fx83.0b8

Affected platforms

• Windows 10
• Ubuntu 18.04

Steps to reproduce

1. Open Firefox with a new profile.
2. Enable browserconsole.
3. Open browser console and use the following snippet to modify the profile age:

(async function() { let { ProfileAge } = ChromeUtils.import("resource://gre/modules/ProfileAge.jsm"); let age = await ProfileAge(); age._times = { firstUse: 1368255600000, created: 1368255600000 }; await age.writeTimes(); })(); 

4. Close the browser console.
5. Close and reopen the browser.

Expected result

• Show the Search Tips on a new tab in the same session, after the interaction with the modal has taken place.

Actual result

• The check_default_browser modal is shown at the start-up while also the Search Tips are shown.

Regression range

• Will come back with a regression range ASAP.
• This is a regression, as the exact same issue was fixed back in Fx75/Fx76. See 1622195 for more details.

Additional notes

• Please note that the issue does not occur in Nightly. Might be because in Nightly the default browser check is no longer done via a modal window.

I don't think this is worth squeezing into 83. In bug 1673048, it looks like the new default browser prompt will ride to Release 84, making fixing this bug a low priority. Still, it might be worth fixing if other modals are affected. I'd be curious to see a regression window.

Since I had to do a manual regression due to the nature of the bug, the best I could narrow it down to was:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=31fb4a2a69124b6a21e5d8f44a0407d489749407&tochange=933c9f34edfab8d5cf2a5389304cf3708889eb1c

• Lask known good build: Fx 80.0a1 - https://hg.mozilla.org/mozilla-central/rev/31fb4a2a69124b6a21e5d8f44a0407d489749407
• First known bad build: Fx 80.0a1 - https://hg.mozilla.org/mozilla-central/rev/933c9f34edfab8d5cf2a5389304cf3708889eb1c

From that list bug 1646086 stands out as a possible regressor, but I might be wrong.