Closed Bug 1675349 Opened 3 years ago Closed 3 years ago

[meta] Disable plugin support

Categories

(Core Graveyard :: Plug-ins, task, P1)

Tracking

(relnote-firefox 84+, firefox-esr78 wontfix, firefox82 wontfix, firefox83 wontfix, firefox84 wontfix, firefox85 fixed)

RESOLVED FIXED
85 Branch
Tracking Status
relnote-firefox --- 84+
firefox-esr78 --- wontfix
firefox82 --- wontfix
firefox83 --- wontfix
firefox84 --- wontfix
firefox85 --- fixed

People

(Reporter: handyman, Assigned: handyman)

References

Details

(Keywords: dev-doc-complete, feature-testing-meta)

Attachments

(19 files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review

We are removing support for plugins. The current plugin behavior will be replaced with a transparent element. All currently supported plugin use (i.e. only MIME types "x-shockwave-flash" and "x-test" variants) will always use the transparent element. The fallback is specifically not dependent on whether the plugin is installed, whether it exists in a blocklist or what the users CTP settings may be.

The browser currently only enables plugin behavior for Flash and our internal test plugins. This patch replaces support for those plugins with a simple fallback that shows a transparent region where the plugin would have been. It removes the file system search(es) for the plugin dynamic libraries and short-circuits the logic to determine if plugins should do something special -- all implementations now behave the same in the presence of plugin elements.

The new behavior is:

  1. If the <object> or <embed> element lists a type of something other than "x-shockwave-flash" or "x-test" then the behavior is unchanged. This means that non-plugin types behave properly and unknown types (for example, typos) are also unaffected (they reduce to 0x0 elements).
  2. If the <object> element has an HTML fallback in the DOM (see spec for <object> elements) then the fallback is always shown.
  3. Otherwise, the element is shown as a transparent region with the size specified in attributes.

As part of the fallback for unsupported plugin elements, we deny them focus. Since elements can be programmatically changed, and object/embed elements can change internal "type" by updating their data/src attributes, and because that type is decided asynchronously, we may need to give up focus if our element has it.

Depends on D95902

Remove some support files for plugin features and stop building TestPlugins.

Depends on D95903

UPDATED

accessible/tests/mochitest/elm/test_HTMLSpec.html
Bug 905215
Test that a11y shadow DOM gets objects of the right type and state from HTML dom.
Changed <object> and <embed> plugin tests to find no accessible.

accessible/tests/mochitest/elm/test_MathMLSpec.html
Bug 1001634
Basic MathML a11y tests. Didn't use plugin, just initializes it.
Remove plugin initialization.

accessible/tests/mochitest/elm/test_plugin.html
Test that a11y shadow tree gets proper type/state for plugin objects and their subtrees, even if there is an HTML fallback provided.
Removed.

accessible/tests/mochitest/focus/test_takeFocus.html
Bug 677467
Test that a11y shadow tree focus follows DOM focus
Remove plugin init but keep plugin test.

Depends on D95904

UPDATED

browser/base/content/test/plugins/browser_CTP_favorfallback.js
Test that plugin fallback behavior is correct.
Updated to reflect that plugins always show "alternate" content, which is either the user fallback of the browser's transparent fallback, regardless of the HTML.

browser/base/content/test/plugins/browser_CTP_outsideScrollArea.js
Test that overlay is visible (in layout sense) only if plugin is partially or completely visible.
Changed to test new fallback behavior where overlay is a hidden element with "blockall" atribute.

browser/base/content/test/plugins/browser_CTP_zoom.js
Test that overlay is present and visible at multiple zoom levels.
Adjusted to work with hidden overlay.

browser/base/content/test/performance/browser_startup_mainthreadio.js
Track IO done at browser startup
Removed UserPlugins.parent from list since we no longer scan for plugins.

browser/base/content/test/plugins/browser_bug797677.js
bug 797677
Test that plugin instantiation fails (with PLUGIN_UNSUPPORTED and no console error) when MIME type missing.
Removed the cleanup of (unused) test plugin.

browser/base/content/test/contextMenu/browser_contextmenu.js
Test context menu for many types of elements
Removed plugin element portion.

REMOVED

browser/base/content/test/plugins/browser_CTP_contextmenu.js
Test that the CTP activate action in content menus for plugins works

browser/base/content/test/plugins/browser_CTP_crashreporting.js
Test that plugin crash submissions still work properly after click-to-play activation.

browser/base/content/test/plugins/browser_CTP_drag_drop.js
Test that plugin CTP dialog behaves correctly when dragging tab out of/into a window

browser/base/content/test/plugins/browser_CTP_hide_overlay.js
Test ability to close plugin "overlay" placeholder (the grey lego element)

browser/base/content/test/plugins/browser_CTP_iframe.js
Test that overlay can be interacted with (closed) when in an iframe

browser/base/content/test/plugins/browser_CTP_nonplugins.js
Bug 926605
Says it tests that non-plugin <object> elements don't show CTP but it doesn't. It tests that removing a CTP plugin from a page does not remove CTP dialog (in case, for example, page shows, then quickly removes plugin).

browser/base/content/test/plugins/browser_CTP_overlay_styles.js
Verify that styling on overlay elements, based on sizing, is correct.

browser/base/content/test/plugins/browser_CTP_resize.js
Test that a resize properly updates the overlay styling, which is only visible when large enough.

browser/base/content/test/plugins/browser_CTP_shouldShowOverlay.js
Test that partially obscured plugins show the overlay, properly styled (when they should).

browser/base/content/test/plugins/browser_blocking.js
bug 1129040
Test CTP behavior -- overlay dialog behavior, vulnerable plugin user approval, plugin's infoURL, etc.

browser/base/content/test/plugins/browser_blocklist_content.js
bug 1129040
Test (plugin) blocklist, including attempt to "hack" it in a content process.

browser/base/content/test/plugins/browser_bug743421.js
Test CTP approval persists for new plugin instances in page.

browser/base/content/test/plugins/browser_bug744745.js
Test that CTP notification correctly appears despite plugin with opacity: 0 !important

browser/base/content/test/plugins/browser_bug787619.js
bug 787619
Make sure CTP works for plugins nested inside <a></a> elements.

browser/base/content/test/plugins/browser_bug812562.js
bug 812562
Navigating away from, then back to a page should restore its CTP status.

browser/base/content/test/plugins/browser_bug818118.js
bug 818118
Test that CTP plugin and "unknown" plugin type work correctly on same page.

browser/base/content/test/plugins/browser_clearplugindata.js
Test clearing plugin data using Sanitizer.jsm

browser/base/content/test/plugins/browser_iterate_hidden_plugins.js
Bug 1318383
Test plugins.navigator.hidden_ctp_plugin, which hides CTP plugins from navigator.plugins.

browser/base/content/test/plugins/browser_pluginCrashCommentAndURL.js
Test plugin crash detection and reporting

browser/base/content/test/plugins/browser_pluginCrashReportNonDeterminism.js
Bug 1110887
Test both "plugin process crash notification" orders -- content proc before main proc and vice-versa.

browser/base/content/test/plugins/browser_plugin_reloading.js
Bug 1129040
Re-instantiating plugin (using plugin.src = new_value) should retain CTP approval.

browser/base/content/test/plugins/browser_plugin_framed_domain.js
Plugin CTP prompts should adopt top-level page's principal for instead of closest frame's principal.

browser/base/content/test/plugins/browser_pluginnotification.js
Tests many CTP interface behavior cases -- doorhangers, overlays, multiple plugin instances, CTP choices (always, allow, never)

browser/base/content/test/plugins/browser_private_clicktoplay.js
Make sure CTP interface works in private windows

browser/base/content/test/plugins/browser_subframe_access_hidden_plugins.js
Allow navigator.plugins to list plugin after CTP approval, even if it listed in plugins.navigator.hidden_ctp_plugin

Depends on D95905

REMOVED

browser/components/enterprisepolicies/tests/browser/browser_policy_disable_flash_plugin.js
Bug 1429169
Flash ctp/disabled by enterprise policy.

browser/components/extensions/test/browser/browser_ext_browsingData_pluginData.js
Test plugindata part of the browsingData extension's use of nsIClearDataService (so, same as ForgetAboutSite above).

Depends on D95906

UPDATED

dom/base/test/browser_timeout_throttling_with_audio_playback.js
Test background tab audio throttling
Remove plugin portion

Depends on D95907

UPDATED

dom/html/test/test_object_plugin_nav.html
Test focus behavior around <object> element.
Rename to test_object_nav.html and switch to use image/png instead of application/x-test (test plugin)

dom/html/test/test_fullscreen-api.html
Test fullscreen, including in the context of a plugin.
Remove plugin portion of test and the "skip" list that was added to allow headless/linux tests to skip only the plugin part due to bugs 1409805 and 1330553.

REMOVED

dom/html/test/test_iframe_sandbox_plugins.html
Test that sandbox attribute on iframe blocks/loads plugins correctly

Depends on D95908

ADDED/UPDATED

dom/plugins/test/mochitest/browser_blockallplugins.js
Make sure that all plugin elements use the fallback for removed plugins.

dom/plugins/test/mochitest/test_mixed_case_mime.html
Bug 206659
Test MIME-type case sensitivity using "application/x-Second-Test"
Change to test "image/png".

dom/plugins/test/mochitest/test_plugin_fallback_focus.html
Test that (denying) object/embed focus and focusability are properly maintained when those elements change type to/from plugins.

REMOVED

dom/plugins/test/unit/test_nice_plugin_name.js
bug 838290
Plugin permission string is "nicely" based on plugin lib name.

dom/plugins/test/unit/test_bug471245.js
bug 471245
Something to do with disabled plugins being enabled under some weird condition.

dom/plugins/test/unit/test_bug813245.js
bug 813245
Plugin registry file doesn't cause crash or incorrectly represent real plugin.

dom/plugins/test/unit/test_bug854467.js
bug 854467
PluginTag correctly controls click-to-play behavior.

dom/plugins/test/unit/test_plugin_default_state.js
bug 866390
Click-to-play abides plugin.default.state setting.

dom/plugins/test/unit/test_persist_in_prefs.js
Bug 830267
CTP state is maintained in settings (not pluginreg.dat) and persists regardless of plugin removal

dom/plugins/test/mochitest/test_NPNVdocumentOrigin.html
Bug 622199
Test NPNV connection to DOM properly handles documentOrigin.

dom/plugins/test/mochitest/test_NPPVpluginWantsAllNetworkStreams.html
Test NPPV connection to JS when plugin requests all HTTP stream <body>s (including failed requests)

dom/plugins/test/mochitest/test_bug1028200-*.html
Properly handle fullscreen wrt plugins doing things (like crashing)

dom/plugins/test/unit/test_bug471245.js
Bug 471245
Extensions should not enable inadvertently enable plugins when they consult PluginHost.

dom/plugins/test/unit/test_bug813245.js
Bug 813245
Do not crash when we read a corrupt pluginreg.dat

dom/plugins/test/unit/test_bug854467.js
Bug 854467
Should be able to unset CTP setting in chrome JS.

dom/plugins/test/unit/test_nice_plugin_name.js
Bug 838290
Permission string names for plugins should be pretty and not just based on plugin filename.

dom/plugins/test/unit/test_persist_in_prefs.js
Bug 830267
Persist plugin prefs in user prefs, not pluginreg.dat

dom/plugins/test/unit/test_plugin_default_state.js
Bug 866390
Plugins that use default CTP state should follow changes to the default. Others should not be affected by changes.

dom/plugins/test/mochitest/test_bug1092842.html
bug 1092842
Plugin clipping around specific HTML element attributes.

dom/plugins/test/mochitest/test_bug1165981.html
bug 1165981
Test non-Flash plugins are blocked

dom/plugins/test/mochitest/test_bug1245545.html
bug 1245545
Test unloading plugins based on dom.ipc.plugins.unloadTimeoutSecs

dom/plugins/test/mochitest/test_bug1307694.html
bug 1307694
Test scale and salign attributes musst be processed in an order dependent way. But salign is no longer supported. The test uses special testplugin behavior.

dom/plugins/test/mochitest/test_bug532208.html
bug 532208
Test that plugins can handle large streams, using special testplugin behavior.

dom/plugins/test/mochitest/test_bug539565-1.html
dom/plugins/test/mochitest/test_bug539565-2.html
bug 539565
Plugins should get proper mouse coords in the face of CSS transformations

dom/plugins/test/mochitest/test_bug771202.html
bug 771202
Use JS-exported plugin functions after plugin is moved to a subdocument.

dom/plugins/test/mochitest/test_bug777098.html
bug 777098
Test that plugin is properly deleted and a JS exception is thrown when an invalid NPObject (from a dead instance) is passed to a plugin.

dom/plugins/test/mochitest/test_bug784131.html
bug 784131
Plugins should properly stop when they lose their frames (via e.g. display:none)

dom/plugins/test/mochitest/test_bug813906.html
bug 813906
Make sure plugins can't access chrome-privileged pages

dom/plugins/test/mochitest/test_bug852315.html
bug 852315
Tests a specific case where JS code that added an element in response to an <embed> event handler would alter a hash table in the midst of iteration, causing a crash.

dom/plugins/test/mochitest/test_bug854082.html
bug 854082
Tests that destroying the plugin's frame inside NPP_New does not cause a crash

dom/plugins/test/mochitest/test_bug863792.htm
bug 863792
Do not leak when a plugin removes itself from the document and inactivates the document in its NPP_New

dom/plugins/test/mochitest/test_bug967694.html
bug 967694
CTP dialog should not spawn plugin inside CTP dialog event.

dom/plugins/test/mochitest/test_bug985859.html
bug 985859
navigator.mimetypes should work as case-insensitive hashmap (there don't seem to be any legal mimetypes left now).

dom/plugins/test/mochitest/test_bug986930.html
bug 986930
Properly handle plugin with non-ASCII mime type.

dom/plugins/test/mochitest/test_copyText.html
Plugins should be able to use the clipboard.

dom/plugins/test/mochitest/test_crash_nested_loop.html
Plugins resulting in a call to PluginCrashed while still on the stack causing a browser crash (non-oop plugins). So this is ancient (11 years).

dom/plugins/test/mochitest/test_crashing.html
Bug 560213
Test that plugin crashes generate exceptions and do not lead to heap corruption when using JS to call methods on the crashed plugin.

dom/plugins/test/mochitest/test_CrashService_crash.html
dom/plugins/test/mochitest/test_CrashService_hang.html
dom/plugins/test/mochitest/test_x11_error_crash.html
Bug 983313 and bug 1331320
Check that CrashService (which is currently only used by plugin tests) properly detects plugin crash, hang and crashes from X11 errors.

dom/plugins/test/mochitest/test_crashing2.html
Reloading should restore crashed plugin. Test was already completely disabled.

dom/plugins/test/mochitest/test_defaultValue.html
Bug 679509
Make NPObjects ok to use as a primitve [[DefaultValue]], instead of calling valueOf on the NPObject itself.

dom/plugins/test/mochitest/test_bug751809.html
Bug 751809
Plugin CTP broke plugin input (ancient).

dom/plugins/test/mochitest/browser_bug1335475.js
bug 1335475
Test that plugins aren't available in chrome-privilege, null-principal, and file:// content but are available to http:// and about:blank content

dom/plugins/test/mochitest/browser_data_url_plugin.js
Bug 1381755
Test that data URIs inside iframes can't use plugins

dom/plugins/test/mochitest/browser_bug1196539.js
Test that plugin repaints when it should (and not more than that, modulo OS repaints)

dom/plugins/test/mochitest/test_hidden_plugin.html
Test navigator.plugins, including that disabling plugins removes them from navigator.plugins

dom/plugins/test/mochitest/test_enumerate.html
Test PluginHost's ability to expose plugin's JS API (looks for TestPlugin's SetColor)

dom/plugins/test/mochitest/test_clear_site_data.html
Directly test PluginHost's clearSiteData API.

dom/plugins/test/mochitest/test_instance_re-parent.html
Bug 90268
Test that reparenting plugin instance in DOM before spinning event loop does not destroy or restart it.

dom/plugins/test/mochitest/test_instance_unparent1.html
dom/plugins/test/mochitest/test_instance_unparent2.html
dom/plugins/test/mochitest/test_instance_unparent3.html
Bug 90268
Test that removing plugin from DOM destroys it (1) normally, (2) if reparented and removed in the same event cycle and (3) when its parent is the element that gets removed.

dom/plugins/test/mochitest/test_instantiation.html
Create that plugin is loaded when element is programmatically created (using createElement).

dom/plugins/test/mochitest/test_multipleinstanceobjects.html
Test NPObject access from multiple plugin instances

dom/plugins/test/mochitest/test_newstreamondestroy.html
Test calling NPN_GetURL from NPP_Destroy

dom/plugins/test/mochitest/test_npn_timers.html
Test NPN_Timer

dom/plugins/test/mochitest/test_npobject_getters.html
Test pluginFoundElement and pluginFoundWindow JS properties set on plugin instance by NPP_New.

dom/plugins/test/mochitest/test_npruntime_construct.html
Test that NP plugin JS method constructObject properly configures prototype chain

dom/plugins/test/mochitest/test_npruntime_identifiers.html
Test various ways the plugin JS reflection method can convert "identifiers" to JS values.

dom/plugins/test/mochitest/test_npruntime_npnevaluate.html
Test NPN_Evaluate (i.e. plugin executing JS code)

dom/plugins/test/mochitest/test_npruntime_npninvoke.html
Test NPN_Invoke (i.e. plugin calling JS method)

dom/plugins/test/mochitest/test_npruntime_npninvokedefault.html
Test NPN_InvokeDefault (i.e. plugin calling default JS method)

dom/plugins/test/mochitest/test_painting.html
Test invalidation and repaint requests for clipped plugins.

dom/plugins/test/mochitest/test_pluginstream_err.html
Bug 517078
Test that plugin streaming error reporting works

dom/plugins/test/mochitest/test_pluginstream_post.html
dom/plugins/test/mochitest/test_pluginstream_poststream.html
Test NPN_PostURL responds (1) by inserting response into given element or (2) by sending response to plugin with NPN_NewStream.

dom/plugins/test/mochitest/test_bug479979.xhtml
Bug 479979
NPN_SetValue should return error for unknown variables.

dom/plugins/test/mochitest/test_crash_notify.xhtml
dom/plugins/test/mochitest/test_crash_notify_no_report.xhtml
Check event data, crash report/minidump (or not using MOZ_CRASHREPORTER_NO_REPORT), etc for plugin-crash event.

dom/plugins/test/mochitest/test_crash_submit.xhtml
dom/plugins/test/mochitest/test_hang_submit.xhtml
Test plugin crash/hang report submission using mock server from toolkit.

dom/plugins/test/mochitest/test_pluginstream_referer.html
Bugs 410904 and 724465
Test NPN_PostURLNotify and NPN_GetURLNotify.

dom/plugins/test/mochitest/test_pluginstream_src.html
Test NPP_NewStream and NPP_DestroyStream using embed tag streammode/streamchunksize parameters.

dom/plugins/test/mochitest/test_pluginstream_src_dynamic.html
Bug 90268
Like test_pluginstream_src.html but using dynamic HTML elements.

dom/plugins/test/mochitest/test_pluginstream_src_referer.html
Bug 737433
Make sure plugin stream data includes the correct referrer (taken from its content)

dom/plugins/test/mochitest/test_propertyAndMethod.html
Test NPObject with property and method with the same name

dom/plugins/test/mochitest/test_queryCSSZoomFactor.htm
Bug 1171182
Test CSS zoom with plugins (handled with NPNVcontentsScaleFactor)

dom/plugins/test/mochitest/test_redirect_handling.html
Test NPN_PostURLNotify and NPN_GetURLNotify URL redirect support.

dom/plugins/test/mochitest/test_secondPlugin.html
Bug 749257
Test navigator.plugins and navigator.mimeTypes (via index and iteration) for proper behavior WRT active, CTP and disabled plugins.

dom/plugins/test/mochitest/test_src_url_change.html
Bug 726734
Changing embed src tag should destroy/restart plugin.

dom/plugins/test/mochitest/test_streamNotify.html
Test that plugin streams properly handle all URLs, including proper errors for malformed URLs.

dom/plugins/test/mochitest/test_streamatclose.html
Any open streams should be notified before NPP_Destroy.

dom/plugins/test/mochitest/test_stringHandling.html
Bug 1106552
Properly handle 0 bytes in strings passed to plugins as NPVariants.

dom/plugins/test/mochitest/test_visibility.html
Make sure plugins respect visibility attribute and issue the correct number of paints.

dom/plugins/test/mochitest/test_zero_opacity.html
Windowed plugins should use clip rect to avoid drawing opacity:0 displays.

dom/plugins/test/mochitest/test_cocoa_window_focus.htm
Test that NPCocoaEventWindowFocusChanged is properly sent for plugin's window

dom/plugins/test/mochitest/test_cocoa_focus.htm
Test that NPCocoaEventFocusChanged is properly sent for plugin's element

dom/plugins/test/mochitest/test_windowed_invalidate.html
Test NPN_Invalidate for windowed plugins

dom/plugins/test/mochitest/test_windowless_flash.htm
Make sure Flash always runs in windowless mode

dom/plugins/test/mochitest/test_windowless_ime.html
Test (windowless) plugins with IME

dom/plugins/test/mochitest/test_busy_hang.xhtml
dom/plugins/test/mochitest/test_idle_hang.xhtml
Test plugin busy/idle detection observers and events

dom/plugins/test/mochitest/test_object.html
Bug 783059
Test plugin "instantiation", mostly by stressing behavior when the plugin's element tags are programmatically updated.

dom/plugins/test/mochitest/test_convertpoint.xhtml
Test coordinate space transformations via NPN_ConvertPoint.

dom/plugins/test/mochitest/test_hangui.xhtml
Test the plugin hung UI.

dom/plugins/test/mochitest/test_npruntime.xhtml
Simple test that npruntime (the JS/plugin bridge) works.

dom/plugins/test/mochitest/test_plugin_tag_clicktoplay.html
Make sure nsIPluginTags click-to-play state properly matches enabledState of plugin (in chrome code)

dom/plugins/test/mochitest/test_privatemode_perwindowpb.xhtml
Check that plugins can properly determine when run in private mode with NPNVprivateModeBool.

dom/plugins/test/mochitest/test_wmode.xhtml
Bad test that ends up checking the constant boolean in testplugin returned by pluginSupportsWindowMode() and "confirming" that mac and Linux don't support windowed mode but Windows does.

dom/plugins/test/mochitest/test_xulbrowser_plugin_visibility.xhtml
Tests that plugins properly get visibility and invalidate messages when in the current or not-current tab.

Depends on D95909

UPDATED

dom/security/test/mixedcontentblocker/file_main.html
Bug 62178
Test "insecure requests from a secure context".
Switch to use image/png instead of application/x-test (test plugin) when testing <object>

Depends on D95910

REMOVED

dom/tests/mochitest/bugs/test_bug427744.html
Test that navigator.plugins properly includes testplugin

Depends on D95911

UPDATED

layout/base/tests/test_bug629838.html
bug 629838
Make sure MozPaintCount and MozAfterPaint are in sync, even with empty transactions
Switch to a <div> and use CSS. MozPaintCount is otherwise largely untested.

layout/base/tests/test_mozPaintCount.html
bug 563864
Test MozPaintCount.
Switch to a <div> and use CSS.

REMOVED

layout/base/tests/chrome/test_chrome_over_plugin.xhtml
Test that plugins are properly clipped wrt translucent chrome elements and not by translucent content elements.

Depends on D95912

REMOVED

layout/generic/test/test_invalidate_during_plugin_paint.html
Bug 564991
Test plugin Invalidating in the midst of painting.

layout/generic/test/test_plugin_focus.html
Bug 520462
Test plugin focus properly set by mouse click.

layout/generic/test/test_plugin_mouse_coords.html
Bug 506304
Test plugin properly receives mouse events.

layout/generic/test/test_plugin_clipping.xhtml
layout/generic/test/test_plugin_clipping_2.xhtml
layout/generic/test/test_plugin_clipping_table.xhtml
layout/generic/test/test_plugin_clipping_transformed.xhtml
Test plugin clipping. "It includes tests for plugins partially covered by opaque HTML content, tests for clip region changes due to scrolling, tests for clip region changes due to z-index changes, and tests for correct plugin clip regions in the presence of subpixel geometry." Also in the presence of tables and moz-transforms.

Depends on D95913

Disables reftests with results that require TestPlugin.

Depends on D95914

REMOVED

testing/mochitest/chrome/test_sanityPluginUtils.html
Test the PluginUtils mochitest helper, which is now unused.

Depends on D95915

REMOVED

toolkit/components/url-classifier/tests/browser/browser_flashblock_{on,off}with{always,ask to,never}_activate.js
bug 1350381
Test Flash user pref and Flash Block combination wrt sites blocklisted in different ways

toolkit/components/forgetaboutsite/test/browser/browser_clearplugindata.js
Test plugindata part of ForgetAboutSite's use of nsIClearDataService, which uses nsPluginHost to call's the plugin's (here, testplugin's) exported NPP_ClearSiteData function.

Depends on D95916

REMOVED

toolkit/content/tests/browser/browser_mute_plugIn.js
Use special test plugin APIs to test mute button on tab (a different test does the same with WebAudio)

toolkit/content/tests/browser/browser_delay_autoplay_plugIn.js
Test that plugin's tab is muted when opened in tab that isn't the current tab

Depends on D95917

UPDATED

toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_severities.js
Bug 1257565
Tests blocklist behavior: user vs soft vs app disabled when blocklist is updated. Does not test severity:0, which :gijs assures me is not relevant to addons.
Remove plugin parts -- seems to be just cutting stuff.

toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_appversion.js
Bug 1257565
Checks that addons are properly blocked by blocklist BASED ON VERSION NUMBERS. NB: result for addons is always STATE_BLOCKED.
Remove plugin parts -- seems to be mostly just cutting stuff. (Also remove 'lastTest' stuff, which is there only for plugins)

REMOVED

toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_plugin_flashonly.js
Bug 1257565
Ostensibly tests plugin.load_flash_only but many tests implicitly test this as it is required to load test plugins.

toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_plugin_regexp.js
Bug 1257565
Not run -- not listed in ini

toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_plugin_outdated.js
bug 514327
Test plugin blocklist value's behaviors

toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_pluginBlocklistCtp
Bug 1257565
Test plugin blocklist (CTP only).

toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_plugin_severities.js
Bug 1257565
Tests severity:0, which, according to :gijs, is not used for addons.

toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_pluginInfoURL.js
Bug 1257565
Assuming infoURL is unused by addons (ask :gijs!), this is all plugins.

toolkit/mozapps/extensions/test/browser/browser_CTP_plugins.js
bug 549697
Test CTP behavior (blocking prefs window, doorhanger, etc)

toolkit/mozapps/extensions/test/browser/browser_html_plugins.js
Bug 1525174
Test plugin activation dropdown in about:addons

toolkit/mozapps/extensions/test/browser/browser_pluginprefs.js
Bug 619652
Testing the rest of plugins use in about:addons

toolkit/mozapps/extensions/test/xpcshell/test_plugins.js
Bug 552736
"This verifies that plugins exist and can be enabled and disabled." Tests basic AddonManager plugin functionality.

Depends on D95918

UPDATED

widget/tests/test_imestate.html
Test that plugin IME state properly tracks focus
Update to reflect that plugins are not IME focusable.

REMOVED

widget/tests/test_plugin_scroll_consistency.html
On most platforms does nothing but on Windows performs basic test that layout positions and sizes are internally consistent.

widget/tests/test_chrome_context_menus_win.xhtml
Make sure that right-clickable chrome context menus appear when a plugin has focus.

widget/tests/test_plugin_input_event.html
Test plugin keyboard input

Depends on D95919

Blocks: 1661450
See Also: → 1086668

if i get things right, removing plugin support will also drop the dependency on gtk+2 (bug #1377445) that is still here for npapi (#1663588) ?

Depends on: 1677137
Summary: Remove plugin support → Disable plugin support
No longer depends on: 1677137
No longer blocks: 1661450, 1675106, 1676542

Firefox 84 Release Note Request:

[Why is this notable]: We will be removing Flash support in Fx85. We'd like to give users a heads up that any sites using Flash might stop working.
[Affects Firefox for Android]: No
[Suggested wording]: Firefox version 84 will be the final version to support Adobe Flash. There will be no setting available to re-enable Flash support.
[Links (documentation, blog post, etc)]: SUMO article: https://support.mozilla.org/en-US/kb/end-support-adobe-flash
Firefox 85 Release Note Request:

[Why is this notable]: We will be removing Flash support in Fx85. We'd like to give users a heads up that any sites using Flash might stop working.
[Affects Firefox for Android]: No
[Suggested wording]: Firefox no longer supports Adobe Flash. There is no setting available to re-enable Flash support.
[Links (documentation, blog post, etc)]: SUMO article: https://support.mozilla.org/en-US/kb/end-support-adobe-flash

relnote-firefox: --- → ?

Added to the Beta 84 relnotes. Leaving the nomination for now until 85 gets covered too.

(In reply to Ryan VanderMeulen [:RyanVM] from comment #22)

Added to the Beta 84 relnotes. Leaving the nomination for now until 85 gets covered too.

Ryan, the SUMO URL I provided above has changed:

Flags: needinfo?(ryanvm)
Flags: needinfo?(ryanvm)
Pushed by daparks@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/769e5c0db4c2
Replace plugin behavior with a basic fallback r=jmathies,mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/2f3eaf9c342c
Forbid elements representing blocked plugins from accepting focus r=jmathies
https://hg.mozilla.org/integration/autoland/rev/3255c1ab3059
Remove unused files following removing plugin support r=jmathies,extension-reviewers,geckoview-reviewers,agi,mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/38e9af69ae57
Update tests under accessible/tests/mochitest to reflect the removal of plugins. r=jmathies
https://hg.mozilla.org/integration/autoland/rev/c84bfb6eae59
Update tests under browser/base/content/test for the removal of plugins. r=jmathies
https://hg.mozilla.org/integration/autoland/rev/43d349fa37b1
Update tests under browser/components for the removal of plugins. r=jmathies,mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/59a0cb79c7c1
Update tests under dom/base for the removal of plugins. r=jmathies
https://hg.mozilla.org/integration/autoland/rev/1cee4d97f801
Update tests under dom/html/test for the removal of plugins. r=jmathies
https://hg.mozilla.org/integration/autoland/rev/7fc67a9b2932
Update tests under dom/plugins/test for the removal of plugins. r=jmathies
https://hg.mozilla.org/integration/autoland/rev/48f153341af6
Update tests under dom/security/test for the removal of plugins. r=jmathies
https://hg.mozilla.org/integration/autoland/rev/c888dfcdf70e
Update tests under dom/tests/mochitest for the removal of plugins. r=jmathies
https://hg.mozilla.org/integration/autoland/rev/d9723f3a3a7e
Update tests under layout/base for the removal of plugins. r=jmathies
https://hg.mozilla.org/integration/autoland/rev/19e3cb80f469
Update tests under layout/generic for the removal of plugins. r=jmathies
https://hg.mozilla.org/integration/autoland/rev/eb913f58953a
Update tests under layout/tools/reftest for removal of plugins r=jmathies
https://hg.mozilla.org/integration/autoland/rev/28835d4935be
Update tests under testing/mochitest for the removal of plugins. r=jmathies
https://hg.mozilla.org/integration/autoland/rev/f2b16caca1fc
Update tests under toolkit/components for the removal of plugins. r=jmathies
https://hg.mozilla.org/integration/autoland/rev/37fca259c7e9
Update tests under toolkit/content for the removal of plugins. r=jmathies
https://hg.mozilla.org/integration/autoland/rev/ba5724069dd4
Update tests under toolkit/mozapps for the removal of plugins. r=jmathies,Gijs
https://hg.mozilla.org/integration/autoland/rev/244e0f2b410c
Update tests under widget/tests for the removal of plugins. r=jmathies
Pushed by daparks@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9036b58142b5
Replace plugin behavior with a basic fallback r=jmathies,mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/c0ff7dbb807e
Forbid elements representing blocked plugins from accepting focus r=jmathies
https://hg.mozilla.org/integration/autoland/rev/847bd43fd835
Remove unused files following removing plugin support r=jmathies,extension-reviewers,geckoview-reviewers,agi,mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/dd70b7c8df80
Update tests under accessible/tests/mochitest to reflect the removal of plugins. r=jmathies
https://hg.mozilla.org/integration/autoland/rev/05e018338f4e
Update tests under browser/base/content/test for the removal of plugins. r=jmathies
https://hg.mozilla.org/integration/autoland/rev/e38cc205b04c
Update tests under browser/components for the removal of plugins. r=jmathies,mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/b712e934ced5
Update tests under dom/base for the removal of plugins. r=jmathies
https://hg.mozilla.org/integration/autoland/rev/4d3ed7f582f5
Update tests under dom/html/test for the removal of plugins. r=jmathies
https://hg.mozilla.org/integration/autoland/rev/bb1aa4e811e7
Update tests under dom/plugins/test for the removal of plugins. r=jmathies
https://hg.mozilla.org/integration/autoland/rev/532462f729f9
Update tests under dom/security/test for the removal of plugins. r=jmathies
https://hg.mozilla.org/integration/autoland/rev/7c947bf2da11
Update tests under dom/tests/mochitest for the removal of plugins. r=jmathies
https://hg.mozilla.org/integration/autoland/rev/f5e95d5032c3
Update tests under layout/base for the removal of plugins. r=jmathies
https://hg.mozilla.org/integration/autoland/rev/c62f92f7a480
Update tests under layout/generic for the removal of plugins. r=jmathies
https://hg.mozilla.org/integration/autoland/rev/f4905769367b
Update tests under layout/tools/reftest for removal of plugins r=jmathies
https://hg.mozilla.org/integration/autoland/rev/501af68874b2
Update tests under testing/mochitest for the removal of plugins. r=jmathies
https://hg.mozilla.org/integration/autoland/rev/0d6c7d1c46b1
Update tests under toolkit/components for the removal of plugins. r=jmathies
https://hg.mozilla.org/integration/autoland/rev/07d50962e04f
Update tests under toolkit/content for the removal of plugins. r=jmathies
https://hg.mozilla.org/integration/autoland/rev/787cb1497e86
Update tests under toolkit/mozapps for the removal of plugins. r=jmathies,Gijs
https://hg.mozilla.org/integration/autoland/rev/6f79bd153659
Update tests under widget/tests for the removal of plugins. r=jmathies

should be fixed...

Flags: needinfo?(davidp99)

https://hg.mozilla.org/mozilla-central/rev/9036b58142b50ecf80a42c6e8968a387a84c51cd
https://hg.mozilla.org/mozilla-central/rev/c0ff7dbb807e2c2e57fbcdae68b8b70942886b04
https://hg.mozilla.org/mozilla-central/rev/847bd43fd835e0ef3eb3b25aacf0d0ebf2b97b67
https://hg.mozilla.org/mozilla-central/rev/dd70b7c8df80c1814bc0d3ebd8fc2a0fcea3c26d
https://hg.mozilla.org/mozilla-central/rev/05e018338f4e4e42ae0efa6069abb92a8439ad4d
https://hg.mozilla.org/mozilla-central/rev/e38cc205b04ccf7d48ae98d20659caa1375e4abe
https://hg.mozilla.org/mozilla-central/rev/b712e934ced5d0108dfb9bbf02ec93d61a256405
https://hg.mozilla.org/mozilla-central/rev/4d3ed7f582f503fb36d3eda50fcc55a3e1d8269e
https://hg.mozilla.org/mozilla-central/rev/bb1aa4e811e749e1a186d80cbd6ef386534f5b35
https://hg.mozilla.org/mozilla-central/rev/532462f729f9d132fb2f47964127e124814789f9
https://hg.mozilla.org/mozilla-central/rev/7c947bf2da11bdf2ba9925856cdcbd0910ca1ce8
https://hg.mozilla.org/mozilla-central/rev/f5e95d5032c3359a284e5e0098ef65c583732535
https://hg.mozilla.org/mozilla-central/rev/c62f92f7a480ca25d650f80f4cea599ba11ac6d8
https://hg.mozilla.org/mozilla-central/rev/f4905769367beab61c983533cd7138da6023c6b4
https://hg.mozilla.org/mozilla-central/rev/501af68874b25a998df17beeec5d96d79398ec1c
https://hg.mozilla.org/mozilla-central/rev/0d6c7d1c46b1a12b594b1b2f7763a7f5f1a6c103
https://hg.mozilla.org/mozilla-central/rev/07d50962e04f05300d94e5f2c78d83d36269f260
https://hg.mozilla.org/mozilla-central/rev/787cb1497e8641e9879d57d9ff75ce22a6e6e585
https://hg.mozilla.org/mozilla-central/rev/6f79bd1536596ad0fff306190792654177d4c3bd

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
Depends on: 1678280

Firefox 85 Release Note Request:

[Why is this notable]: We will be removing Flash support in Fx85. We'd like to give users a heads up that any sites using Flash might stop working.
[Affects Firefox for Android]: No
[Suggested wording]: Firefox no longer supports Adobe Flash. There is no setting available to re-enable Flash support.
[Links (documentation, blog post, etc)]: SUMO article: https://support.mozilla.org/kb/end-support-adobe-flash

(In reply to Ryan VanderMeulen [:RyanVM] from comment #22)

Added to the Beta 84 relnotes. Leaving the nomination for now until 85 gets covered too.

Resetting relnote-firefox nom flag to ? for our 85 release note.

It's already in the relnotes for 85.0a1, I'll carry it forward to beta and release.

Summary: Disable plugin support → [meta] Disable plugin support

Docs completed on MDN. Plugins pages updated with the new info, and rel note added: https://github.com/mdn/content/pull/1505

Let me know if you think this needs anything else. Thanks!

Blocks: 1747065
Product: Core → Core Graveyard
Blocks: 1816182
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: