Closed Bug 1672464 Opened 4 years ago Closed 4 years ago

Block WebRender for NVIDIA users with mixed refresh rates

Categories

(Core :: Graphics: WebRender, task, P1)

Product:
Core
Component:
Graphics: WebRender
Platform:
Desktop
Windows
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
84 Branch
Tracking Flags:
Tracking Status
firefox82 --- disabled
firefox83 --- fixed
firefox84 --- fixed

People

(Reporter: aosmond, Assigned: aosmond)

References

Details

Attachments

(2 files)

Bug 1672464 - Block WebRender for NVIDIA users with mixed refresh rates.
47 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details | Review
Rebased on top of latest beta, v1
12.98 KB, text/plain
Details
No description provided.
Summary: Rollout WebRender to NVIDIA users with high but not mixed refresh rates → Block WebRender for NVIDIA users with not mixed refresh rates
Summary: Block WebRender for NVIDIA users with not mixed refresh rates → Block WebRender for NVIDIA users with mixed refresh rates
Pushed by aosmond@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3476de962c82
Block WebRender for NVIDIA users with mixed refresh rates. r=jrmuizel

https://hg.mozilla.org/mozilla-central/rev/3476de962c82

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox84: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch

Comment on attachment 9183252 [details]
Bug 1672464 - Block WebRender for NVIDIA users with mixed refresh rates.

Beta/Release Uplift Approval Request

  • User impact if declined: Some NVIDIA users will get WebRender and experience issues due to mixed high refresh rate displays.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Currently we are shipping WebRender to all NVIDIA users, at least relative to refresh rate. We just want to turn it off for a relatively small population due to existing issues. It hasn't been verified in nightly because this code path is only active in beta/release, but we do have automated tests written for it.
  • String changes made/needed:
Attachment #9183252 - Flags: approval-mozilla-beta?

Comment on attachment 9183252 [details]
Bug 1672464 - Block WebRender for NVIDIA users with mixed refresh rates.

Approved for 83 beta 5, thanks.

Attachment #9183252 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

This has conflicts caused by bug 1671518. Please attach a rebased patch.

Flags: needinfo?(aosmond)
Flags: needinfo?(aosmond)

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #9)

https://hg.mozilla.org/releases/mozilla-beta/rev/69c189f93184

Note that this missed the b5 build and will be in b6 instead.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: