PiP will not turn off from context menu when "Enable picture-in-picture video controls" is unchecked in Preferences
Categories
(Toolkit :: Video/Audio Controls, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox82 | --- | wontfix |
firefox83 | --- | verified |
People
(Reporter: csasca, Assigned: whjones526, NeedInfo)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
Affected versions
- Firefox 82.0
- Firefox 83.0a1
Affected platforms
- macOS 11
- Ubuntu 20.04
- Windows 10
Steps to reproduce
- Launch Firefox
- Access Preferences and unselect "Enable picture-in-picture video controls" from General section
- Launch a youtube video, right click it and select "Picture-in-picture" option
- Right click again on the video and unselect "Picture-in-picture" option
Expected result
- The video reverts to it's original state and position
Actual result
- The video turns off PIP for a moment then gets back in PIP mode
Regression range
- I will see for a regression if there is one
Additional notes
- The issue can be seen in the following attachment
Suggested severity
- S3
Reporter | ||
Updated•4 years ago
|
Comment 1•4 years ago
|
||
I can reproduce the issue on Nightly83.0a1(20201014214248) Windiows10. However, I cannot on Firefox82.0(20201014125134).
And the problem is reproduced regardless of the option settings.
Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=9270d433458733f104989082c3be6275a2b06146&tochange=10655b36d226857f983388a1a87a85cdae558689
Updated•4 years ago
|
Updated•4 years ago
|
Reporter | ||
Comment 2•4 years ago
|
||
Yes, indeed it is reproducible without disabling the PIP controls, thank you Alice for finding the regression.
Updated•4 years ago
|
Updated•4 years ago
|
Reporter | ||
Updated•4 years ago
|
Reporter | ||
Updated•4 years ago
|
Assignee | ||
Comment 5•4 years ago
|
||
Updated•4 years ago
|
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2fb2e37e5f69 Fix PiP not closing from context-menu r=mconley
Comment 7•4 years ago
|
||
bugherder |
Updated•4 years ago
|
Updated•4 years ago
|
Updated•3 years ago
|
Comment 8•3 years ago
|
||
Reproduced the initial issue on Nightly 83.0a1 (buildID: 20201014214248) on Windows 10 x64.
Verified fixed on Windows 10 x64, Ubuntu 20.04 and macOS 11 using Firefox 83 Beta 10 (buildID: 20201108174701).
Description
•