Closed Bug 1671122 Opened 4 years ago Closed 4 years ago

Second click on Enable HTTPS-Only Mode in all windows checkbox disables the option

Categories

(Core :: DOM: Security, defect, P1)

Firefox 83
defect

Tracking

()

VERIFIED FIXED
83 Branch
Tracking Status
firefox82 --- disabled
firefox83 --- verified
firefox84 --- verified

People

(Reporter: asoncutean, Assigned: julianwels)

References

(Blocks 1 open bug)

Details

(Whiteboard: [domsecurity-active])

Attachments

(2 files)

Attached image screencast issue.gif

Affected versions

  • 83.0a1

Affected platforms

  • Windows 10
  • MacOS 10.11
  • Ubuntu 18.04

Steps to reproduce

  1. Go to about:preferences#privacy
  2. Select the Enable HTTPS-Only Mode in all windows option from HTTPS-Only Mode section
  3. Click the option again

Expected result

  • Nothing happens, the option remains selected

Actual result

  • The option is deselected, the selection is moved to the Don’t enable HTTPS-Only Mode option

Regression range

  • Not a regression, implemented with 1644152

Additional notes

  • Enable HTTPS-Only Mode in private windows only and Don’t enable HTTPS-Only Mode options triggered no response on the second click

Suggested severity

  • S4
Has STR: --- → yes

:Anca, if you think that's a regression, then could you try to find a regression range in using for example mozregression?

Thanks for reporting. Julian, should be an easy fix, can you take a look by any chance?

Severity: -- → S2
Priority: -- → P1
Flags: needinfo?(julianwels)
Assignee: nobody → julianwels
Status: NEW → ASSIGNED
Whiteboard: [domsecurity-active]
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b53592263420
Fixed bug where second click on HTTPS-Only Mode enable-checkbox disables it again. r=ckerschb,preferences-reviewers,Gijs
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
Flags: needinfo?(julianwels)
Flags: qe-verify+

Verified fixed with Fx 84.0a1 (2020-10-23) and Fx 83.0b3 on Windows 10 x64 and Ubuntu 18.04.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: