The tab-to-search animation is inverted on RTL builds
Categories
(Firefox :: Address Bar, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox81 | --- | unaffected |
| firefox82 | --- | unaffected |
| firefox83 | --- | verified |
People
(Reporter: ccomorasu, Assigned: bugzilla)
References
Details
(Keywords: rtl)
Attachments
(2 files)
[Affected versions]:
- Fx 83.0a1
[Affected platforms]:
- Windows 10 x64
- macOS 10.13
[Steps to reproduce]:
- Launch a RTL Firefox.
- Bookmark https://www.google.com.
- Open a new tab write "g".
[Expected result]:
- The animation brings the message from left to right.
[Actual result]:
- The animation brings the message from right to left.
[Regression range]:
- This is not a regression.
[Additional notes]:
- Please note the attachment.
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
Pushed by htwyford@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2165f99d5437 Fix tab-to-search animation in RTL locales. r=dao
|
||
Comment 3•4 years ago
|
||
Backed out changeset 2165f99d5437 (Bug 1670926) for causing mochitest failures in test_bug1639328.html
Backout link: https://hg.mozilla.org/integration/autoland/rev/b56bda8f309d3dcd230948789d912552d998e219
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318761479&repo=autoland&lineNumber=5483
|
|
Assignee | |
Comment 4•4 years ago
|
||
I think it's fairly unlikely this patch caused the failures in test_bug1639328.html. That test seems to deal with animation timing in Fission iframes. My patch does deal with an animation, but it only reverses the direction of a simple browser chrome animation in RTL builds. Emilio, I see you wrote the test originally – do you see a reason why my patch might have broken it?
|
||
Comment 5•4 years ago
|
||
It seems way more likely that the failure was caused by bug 1669239, which landed right before your patch... Alexandru, did the backout really fix that intermittent failure?
|
|
||
Comment 6•4 years ago
|
||
Doesn't seem to per bug 1671592...
|
|
Assignee | |
Comment 7•4 years ago
|
||
Thanks Emilio. I'm going to try re-landing this patch.
Pushed by mdeboer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/20ce8d1a1915 Fix tab-to-search animation in RTL locales. r=dao
|
||
Comment 9•4 years ago
|
||
| bugherder | ||
|
|
||
Comment 10•4 years ago
|
||
Emilio, your supposition was correct.
I backed out this bug after seeing the push with failures link with the backfills, sorry for the inconveniences and thank you for looking.
|
||
Updated•4 years ago
|
|
Reporter | |
Comment 11•4 years ago
|
||
We verified this issue using Fx 83.0b2 and Fx 84.0a1(2020-10-22) on Windows 10 x64, Ubuntu 20.04 LTS and macOS 10.13.
Description
•