Open Bug 1670639 Opened 4 years ago Updated 3 years ago

[win] Password import suggestions dropdown remains in one place when resizing the browser

Categories

(Toolkit :: UI Widgets, defect)

Desktop
Windows
defect

Tracking

()

Tracking Status
firefox81 --- wontfix
firefox82 --- wontfix
firefox83 --- fix-optional

People

(Reporter: atrif, Unassigned)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image import_data.gif

Affected versions

  • 83.0a1 (20201011093320)
  • 82.0b9 (20201006142214)
  • 81.0.1 (20200930150533)

Affected platforms

  • Windows 10x64

Steps to reproduce

  1. Open Firefox with a new profile and go to twitter.com.
  2. Resize the browser.

Expected result

  • The browser is resized as expected and the dropdown is closed.

Actual result

  • Password import suggestions drop-down remains in one place.

Regression range

  • Reproducible with Firefox 81.0a1(20200821214648). I will search for one ASAP if there is one.

Notes

  • Attached a screen recording.
  • I cannot reproduce the issue on macOS 10.12 because the drop-down is closed when resizing the browser.

Suggested Severity: S4

Has Regression Range: --- → no
Has STR: --- → yes
QA Whiteboard: [qa-regression-triage]

I've narrowed it down to a build between 2020-08-20 and 2020-08-21 by running mozregression

This is the closest it was able to get:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e375b85cfba38ff5f49493d1d48b7561f7f2f8d7&tochange=432e42cbbc4139efd2319952ec33efe8ff9add3c

I believe the issue might've been introduced by Bug 1648182

Has Regression Range: no → yes

The regression window just points to the commit where we enabled this feature, so I don't think this is really a regression.
We've not been able to reproduce this. What should happen is that in clicking on the window's resize handle, the autocomplete menu gets blur'd and hides - and that happens everytime when we've tested on windows, macosx and linux. So I would be interested in some more detail in the STR here.

Flags: needinfo?(alexandru.trif)
Attached image import_00.gif

(In reply to Sam Foster [:sfoster] (he/him) from comment #2)

The regression window just points to the commit where we enabled this feature, so I don't think this is really a regression.
We've not been able to reproduce this. What should happen is that in clicking on the window's resize handle, the autocomplete menu gets blur'd and hides - and that happens everytime when we've tested on windows, macosx and linux. So I would be interested in some more detail in the STR here.

Hello Sam!
After further looking into this I saw that this is reproducible on twitter. The steps are:

  1. Open Firefox with a new profile and go to twitter.com
  2. Resize the browser making it small and big again multiple times. (please see the attached screen recording)

On pages like Facebook, Reddit, and google login form it seems that I cannot reproduce the issue this way. I can however reproduce a similar one by entering fullscreen with the F11 key. So the steps for this are:

  1. Open Firefox with a new profile and go to facebook.com.
  2. Click on the Password field to show the drop-down suggestion.
  3. Hit F11 on the keyboard to enter fullscreen.

Also regarding the regression range, I used the pref("signon.showAutoCompleteImport", "import"); and got this pushlog by using the twitter example and steps mentioned above: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e98c8caadb972eacf87934257fdb909f7bcf4974&tochange=5690715ef70efb9e6c835e0e0ae63371af1475f7.
So from what I see this is not a regression. I think it's safe to remove the regression keywords unless there is another way to test this that I'm unaware of.
If more information is needed please let me know.

Flags: needinfo?(alexandru.trif)

I'm not sure of the best component for this. The symptom is the login autocomplete popup not hiding when the window is resized or goes into fullscreen (which can be accomplished without moving focus), but any hide-on-blur or hide-on-resize behavior is not managed by the password manager code, we just populate the menu, show it and take events from it.

QA Whiteboard: [qa-regression-triage]
Component: Password Manager → XUL Widgets
Keywords: regression
Severity: -- → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: