Closed Bug 1670008 Opened 4 years ago Closed 4 years ago

The None margin option cannot be selected if failing to validate an invalid field by adjusting a value inside another field

Categories

(Toolkit :: Printing, defect, P2)

Product:
Toolkit
Component:
Printing
Version:
Firefox 83
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
84 Branch
Tracking Flags:
Tracking Status
firefox83 --- verified
firefox84 --- verified

People

(Reporter: asoncutean, Assigned: emmamalysz)

References

(Blocks 1 open bug)

Details

(Whiteboard: [print2020_v83] [old-ui-])

Attachments

(2 files)

screencast-issue.gif
501.55 KB, image/gif
Details
Bug 1670008, Once margins are reevaluated, make sure it's possible to switch to "none"
47 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details | Review
Attached image screencast-issue.gif —

Affected versions

  • 83.0a1 (2020-10-08)

Affected platforms

  • Windows 10
  • Ubuntu 18.04
  • macOS 10.15

Steps to reproduce

  1. Launch Fx
  2. Make sure print.tab-modal.enabled is set on true
  3. Hit Ctrl + P on any page (eg. https://upload.wikimedia.org/wikipedia/commons/4/47/PNG_transparency_demonstration_1.png)
  4. Expand More settings and select Custom option from Margins dropdown
  5. Input a valid value inside the Left field (eg. 2)
  6. Input an invalid value inside the Right field (eg. 8)
  7. Try to validate the Right field by lowering the value from Left field (eg. 1)
  8. Select None option from Margins dropdown

Expected result

  • The None option is set, the adjustment are also visible in print preview

Actual result

  • The Custom option is still display, but the None selection takes effect in print preview

Regression range

  • Not a regression, introduced with the margins custom implementation

Suggested severity

  • S3
Assignee: nobody → emalysz
Severity: -- → S3
Priority: -- → P2
Summary: The None option cannot be selected if failing to validate an invalid field by adjusting a value inside another field → The None margin option cannot be selected if failing to validate an invalid field by adjusting a value inside another field
Status: NEW → ASSIGNED
Has STR: --- → yes
Pushed by emalysz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0b5292f5309d
Once margins are reevaluated, make sure it's possible to switch to "none" r=mstriemer
Pushed by emalysz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/31a08d4d6b82
Once margins are reevaluated, make sure it's possible to switch to "none" r=mstriemer

https://hg.mozilla.org/mozilla-central/rev/31a08d4d6b82

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox84: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch

Comment on attachment 9180780 [details]
Bug 1670008, Once margins are reevaluated, make sure it's possible to switch to "none"

Beta/Release Uplift Approval Request

  • User impact if declined: There will be a bug in our custom margins, and users will face difficulties facing from custom to none margins.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: STR are listed in comment 0
  • List of other uplifts needed: Bug 1669696
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): No string changes
  • String changes made/needed: n/a
Flags: needinfo?(emalysz)
Attachment #9180780 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9180780 [details]
Bug 1670008, Once margins are reevaluated, make sure it's possible to switch to "none"

Approved for 83 beta 2, thanks

Attachment #9180780 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

This issue is verified fixed with Fx 83.0b2 and Fx 84.0a1 (2020-10-20) on Windows 10, Ubuntu 18.04 and macOS 10.15.

Status: RESOLVED → VERIFIED
status-firefox83: fixed → verified
status-firefox84: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: