Closed Bug 1669732 Opened 4 years ago Closed 3 years ago

Add error message for page copies

Categories

(Toolkit :: Printing, defect, P3)

Product:
Toolkit
Component:
Printing
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
87 Branch
Tracking Flags:
Tracking Status
firefox82 --- wontfix
firefox83 --- wontfix
firefox87 --- fixed

People

(Reporter: emilghitta, Assigned: emmamalysz)

References

(Depends on 1 open bug)

Details

(Whiteboard: [print2020_v88] [old-ui-] )

Attachments

(1 file)

Bug 1669732, add error message for invalid number of copies
48 bytes, text/x-phabricator-request
Details | Review

Affected versions

  • Firefox 83.0a1 (BuildId:20201007094223)
  • Firefox 82.0b8 (BuildId:20201006142214)

Affected platforms

  • Windows 10 64bit
  • Ubuntu 18.04 64bit
  • macOS 10.14

Steps to reproduce

  1. Launch Firefox.
  2. Access a random webpage.
  3. Open the print preview.
  4. Delete the value from the copies field.
  5. Input a high value for the copies field (above 1000 copies).

Expected result

  • Step 4: The copies counter is highlighted in red and an error message is displayed stating that the user has to enter a value between 1 and 999.
  • Step 5: The copies value input is limited to 999 copies & a value above that throws and error stating that the user is limited in entering a value between 1 and 999.

Actual result

  • Step 4: The copies counter is highlighted in red but no visible error message is displayed for the user.
  • Step 5: The value that can be entered inside the copies field is not limited to a certain value and it seems that (on Windows) it can overflow the variable at some point.

Regression Window

  • I don’t think that this is a regression.

Additional Information

  • I am pointing out 1 - 999 as the accepted value range after taking Chrome and Microsoft Edge’s accepted values as a reference.
Whiteboard: [print2020_v83]
No longer blocks: wdba-phase2
Depends on: 133787, 1658287

Putting in lots of 9s will also cause this to overflow and become invalid when it wraps around to negative.

Severity: -- → S3
Type: enhancement → defect
Priority: -- → P3
Whiteboard: [print2020_v83] → [print2020_v83][old-ui-]
Has STR: --- → yes
Whiteboard: [print2020_v83][old-ui-] → [print2020_v84][old-ui-]
Whiteboard: [print2020_v84][old-ui-] → [print2020_v85] [old-ui-]

(Moving bugs to 86, part 1.)

Whiteboard: [print2020_v85] [old-ui-] → [print2020_v86][old-ui-]
Assignee: nobody → emalysz

Moving things to 88, cause we're mostly on Proton these days…

Whiteboard: [print2020_v86][old-ui-] → [print2020_v88] [old-ui-]

The counter limit was introduced in Bug 1682290, so for this bug, we only need to add an error message for invalid inputs

Summary: Add counter limit & error message for page copies → Add error message for page copies
Pushed by emalysz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7a68819b7e59
add error message for invalid number of copies r=mstriemer,fluent-reviewers
Status: NEW → ASSIGNED

https://hg.mozilla.org/mozilla-central/rev/7a68819b7e59

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox87: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: