Margins settings have no effect in pdfs
Categories
(Toolkit :: Printing, defect, P2)
Tracking
()
People
(Reporter: asoncutean, Assigned: mstriemer)
References
(Blocks 1 open bug)
Details
(Whiteboard: [print2020_v85][old-ui-])
Attachments
(2 files)
Affected versions
- 83.0a1 (2020-10-07)
- 82.0b8
Affected platforms
- Windows 10
- macOS 10.14
- Ubuntu 18.04
Steps to reproduce
- Launch Fx
- Make sure print.tab-modal.enabled is set on true
- Open any pdf (eg. https://www.irs.gov/pub/irs-pdf/f1040.pdf)
- Hit Ctrl + P
- Expand More settings
- Apply several Margins options from the dropdown
Expected result
- Not exactly sure what is the desired outcome here, (I see that Chrome doesn't support this option in pdf), so either this section should be grayed out or the margins settings should be applied
Actual result
- Margins settings takes no effect
Regression range
- Not a regression
Suggested severity
- S3
|
Assignee | |
Comment 1•4 years ago
|
||
I guess we should just disable the option for PDFs like we do for Color when saving to PDF.
Likewise there are the headers & footer and background options which likely do nothing.
|
||
Updated•4 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 2•3 years ago
|
||
|
|
||
Updated•3 years ago
|
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5f2f88dae91f Hide print settings that don't apply to PDF for PDFs r=sfoster
|
||
Comment 4•3 years ago
|
||
Backed out changeset 5f2f88dae91f (Bug 1669725) for causing linux bc failures in RunWatchdog.
Backout link: https://hg.mozilla.org/integration/autoland/rev/134744b7710546b6bb178c11c6a21a962e8c285a
Failure logs:
|
||
Comment 5•3 years ago
|
||
Looks like the pdf file that got added in the patch was a base64 encoded data-uri, rather than the raw file. Not sure if this caused the errors, but seems at least possible?
|
|
||
Comment 6•3 years ago
|
||
try linux/asan with an updated file_pdf.pdf
try linux/debug
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c9bf4601f27f Hide print settings that don't apply to PDF for PDFs r=sfoster
|
|
||
Comment 8•3 years ago
|
||
| bugherder | ||
|
||
Comment 9•3 years ago
|
||
Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.
|
Reporter | |
Comment 10•3 years ago
|
||
Verified fixed across platforms (Windows 10, Ubuntu 18.04, ,macOS 10.15) with Fx 85.0a1 (2020-12-14).
|
||
Updated•3 years ago
|
|
|
Assignee | |
Updated•3 years ago
|
Description
•