Closed
Bug 1669641
Opened 4 years ago
Closed 3 months ago
Change focus rings to actual rings on [Open menu] buttons in AS page
Categories
(Firefox :: New Tab Page, enhancement, P3)
Tracking
()
RESOLVED
FIXED
People
(Reporter: cfogel, Unassigned)
Details
Attachments
(1 file)
16.24 KB,
image/png
|
Details |
Affected versions
- 82.0b3, 83.0a1(2020-10-05);
Affected platforms
- macOS 10.15, Windows 10/7, Ubuntu 18;
Steps to reproduce
- Launch Firefox, access about:newtab
- Hover over the (...) - Open menu button(s) for any of the tiles;
- Press the TAB key
Enhancement suggestion
- make the focus ring a circle instead of a rectangle with rounded edges;
Actual result
- focus ring displayed;
Regression range
- will check asap;
Additional notes
- S4 as suggested severity;
- attached screenshot to illustrate the point;
- as a note, the current implementation is good as well since as a rectangle it is more visible over the somewhat smaller in-page elements; but it might look cleaner over the rounded ones.
Reporter | ||
Updated•4 years ago
|
Reporter | ||
Comment 1•4 years ago
|
||
Set keywords, to double-check if it was implemented as such or would be a regression.
Flags: needinfo?(cristian.fogel)
Updated•4 years ago
|
Severity: -- → S4
OS: Unspecified → All
Hardware: Unspecified → Desktop
Version: unspecified → Trunk
Comment 2•4 years ago
|
||
Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=77478857971ab508fb62cfcae61b832e6c9c7b94&tochange=e82083f98a4446ce6d30b16cc5487778f6d375e4
Suspect:Bug 1311444
Regressed by: 1311444
Comment 3•4 years ago
|
||
-moz-outline-radius: 50%;
should fix it. But the focus ring is intentional. Alternatively you can suppress it with outline: none
or what not.
Reporter | ||
Updated•4 years ago
|
Comment 4•4 years ago
|
||
Since this is an enhancement request and not a regression, bug 1311444 should be removed from the regressed by field.
Updated•4 years ago
|
Iteration: --- → 84.1 - Oct 19 - Nov 01
Priority: -- → P3
Updated•4 years ago
|
Iteration: 84.1 - Oct 19 - Nov 01 → ---
Comment 5•3 months ago
|
||
This seems like it has been fixed at some point.
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•