Icon from Sign out of Firefox prompt not centered with the message
Categories
(Firefox :: Sync, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox82 | --- | wontfix |
| firefox83 | --- | verified |
People
(Reporter: cfogel, Assigned: lougenia)
References
(Regression)
Details
(Keywords: regression)
Attachments
(3 files)
Screenshot 2020-09-30 at 15.25.09.png
Affected versions
- 82.0b5 DevEd, 83.0a1
Affected platforms
- Windows 10, macOS 10.15;
Steps to reproduce
- Launch Firefox, sync with a valid account;
- Click on userIMG -> Account Settings;
- Click to Sign out;
Expected result
- icon on same row as text;
Actual result
- icon apppears to have the same base-line as the text, instead of looking center-ed (consistency's sake with other icon-text area);
Regression range
- last good: 2020-08-19;
- first bad: 2020-08-20;
- Pushlog: URL;
- mozregression points towards: bug 1657463;
Additional notes
- S4 as suggested severity since it's more down the lines of an enhancement rather than bug;
- attached screenshot to illustrate the issue;
|
Reporter | |
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
Assignee | |
Comment 1•4 years ago
|
||
Christian, can you provide me with an example of the ideal icon-text area spacing?
|
|
Reporter | |
Comment 2•4 years ago
|
||
Attaching an image with the suggested layout.
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 3•4 years ago
|
||
My apologies, I meant to ask for another icon-text area spacing example in desktop whose css I could copy. The problem that I'm having is (on my mac) the spacing doesn't look misaligned. Is there a way for me to test what my change will look like on a windows machine? If not, I can set the vertical alignment for the image, but I won't have a way of assuring that fixes the issue. I'm new to making front-end changes so I'm not sure what the process is. Thanks.
|
|
Reporter | |
Comment 4•4 years ago
|
||
No worries.
Your best bet would be a Virtual Machine such as VirtualBox to emulate a WindowsOS on the machine.
However, I'd like to point out that the issue manifests macOS machines as well; so it should surface for you as well.
If all else fails, looking at it; I'd say that lowering by 5px should do the trick.
|
|
Reporter | |
Comment 5•4 years ago
|
||
Updated the regression-range section on the initial comment.
Visible with change to the content/message/permissions.
|
|
Assignee | |
Comment 6•4 years ago
|
||
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 7•4 years ago
|
||
After speaking with Ana Medinac (product) and getting the blessing of Philip Walmsley (product/UX), I'm removing the icon to circumvent further misalignments resulting from resizing and realigning the icon.
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
Pushed by lobailey@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/154846e026f2 Vertically aligned the sign out icon r=Itiel,markh
|
||
Comment 9•4 years ago
|
||
| bugherder | ||
|
||
Updated•4 years ago
|
|
||
Comment 10•4 years ago
|
||
I have reproduced this issue using Firefox 83.0a1 (2020.09.30) on mac 10.15.
I can confirm this issue is fixed, I verified using Firefox 83.0b2 on macOS 10.15 and Win 8.1 x64, the icon was removed.
|
||
Updated•4 years ago
|
Description
•