Closed Bug 1667726 Opened 4 years ago Closed 4 years ago

The uninstall survey is launched before the user clicks the finish button

Categories

(Firefox :: Installer, defect, P2)

Desktop
Windows 7
defect

Tracking

()

VERIFIED FIXED
83 Branch
Tracking Status
firefox-esr78 --- wontfix
firefox81 --- wontfix
firefox82 --- wontfix
firefox83 --- verified

People

(Reporter: cbaica, Assigned: agashlin)

Details

(Keywords: regression)

Attachments

(2 files)

Attached video uninstall survey bug

Suggested severity

  • S2

Affected versions

  • Fx82.0b4
  • Fx81.0 RC

Affected platforms

  • Windows 7

Preconditions

  • Have Firefox installed (not a zip folder).

Steps to reproduce

  1. Go to the Firefox/uninstall folder.
  2. Run helper.exe.
  3. Proceed with the uninstall process until the panel containing the survey checkbox is reached.
  4. Click the checkbox.

Expected result

  • Checkbox is correctly marked.

Actual result

  • The survey is launched directly, without the user clicking the 'finish' button.

Regression range

  • Will come back with a regression range ASAP.
  • This looks like a recent regression as I could not reproduce the issue on Fx71.0b3.

Additional notes

  • The issue can't be reproduced on the latest Firefox nightly build.
Severity: normal → --
QA Whiteboard: [qa-regression-triage]
Has Regression Range: --- → no
Has STR: --- → yes

Since it's related to running the 'helper.exe' file I had to manually run the regression (download, install and uninstall each build).
I have managed to narrow it down to:
Last known good build: Fx77.0b9 - 20200521224544
First known bad build: Fx78.0b1 - 20200601142750

There are a lot of bugs that went in the first Fx78 beta build, but this was the best I could come up with by doing the manual regression.

Reminder to myself to look into this

Flags: needinfo?(agashlin)

This is fallout from bug 1633505, on the welcome page Flags is set to NOTIFY for Field 4 (the Learn More link) in ioSpecial.ini, this is still present on the finish page, when Field 4 is the survey checkbox, which makes it behave like a button. This is because MUI doesn't re-extract the INI, it just keeps re-writing it, and it doesn't clear fields it didn't know about.

Fortunately this still does approximately what the user would want, since the checkbox starts off clear, but it can be fixed, I think most straightforwardly by deleting the Flags string for Field 4 (and might as well delete all of Field 5 as well).

Assignee: nobody → agashlin
Severity: -- → S3
Flags: needinfo?(agashlin)
Priority: -- → P2
Pushed by agashlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/01747f8308e5
Clean up custom controls when leaving Welcome page. r=mhowell
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
Flags: qe-verify+

The issue is verified fixed using Fx83.0b8 and Fx84.0a1 on Windows 7 and I also did a spot check on Windows 10 as well to make sure there are no regressions there as well.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: