Closed Bug 1667092 Opened 4 years ago Closed 3 years ago

[Win 10] Firefox window is flickering when it is shared in a screen capture

Categories

(Core :: WebRTC, defect, P2)

Desktop
Windows 10
defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox-esr78 --- wontfix
firefox81 --- wontfix
firefox82 --- wontfix
firefox83 --- unaffected

People

(Reporter: mberlinger, Unassigned)

Details

(Keywords: regression)

Attachments

(1 file)

Attached image sharescreen gUM.gif

Suggested severity

  • S3

Affected versions

  • 81.0
  • 82.0b2

Affected platforms

  • Windows 10x64

Preconditions

  • Ensure that hardware acceleration is enabled (about:config -> layers.acceleration.disabled is set to false)

Steps to reproduce

  1. Launch Firefox
  2. Go to https://mozilla.github.io/webrtc-landing/gum_test.html
  3. Access the ScreenSharing/ScreenCapture option.
  4. From the option list select Mozilla Firefox window.

Actual result:
The Firefox window starts flickering

Expected result:
The screensharing is successfully started and no hangs or glitches are triggered.

Regression range

  • This is not a recent regression since I can reproduce it on 79.0. I’ll come back with a regression asap.

Additional notes

  • This issue isn’t reproducible on ubuntu, mac or windows 7.
  • This issue isn’t reproducible on nightly builds.
Has Regression Range: --- → no
Has STR: --- → yes

I don't think this is permission [ui] related.

Component: Site Permissions → WebRTC
Product: Firefox → Core

Hi Maria, thanks for filing! - Do you know if it's a regression? I.e. did it used to work better in older versions of Firefox? If so, would you mind running mozregression to narrow down a regression range?

Also, if you have other browsers installed, are you seeing the same problem there? This would help narrow down if it's an OS/driver issue or Firefox-specific.

Flags: needinfo?(maria.berlinger)

Ensure that hardware acceleration is enabled (about:config -> layers.acceleration.disabled is set to false)

Sorry I missed this part. Is this required to repro? IOW, does it work fine if layers.acceleration.disabled is true? If so, we might punt this over to graphics.

firefox83 --- unaffected

Did it not repro in 83? Dan, are you aware of any recent fixes here?

Flags: needinfo?(dminor)

Bug 1664536 recently landed. That fixed a data race involving the fps calculation, and increased the thread priority for the screen capture thread.

Flags: needinfo?(dminor)

Hello,
I’ve looked for a regression manually and found that Firefox 73.0b8 is the last good build and Firefox 73.0b9 is the first bad build.
Here’s the changelog https://hg.mozilla.org/releases/mozilla-beta/pushloghtml?fromchange=FIREFOX_73_0b8_RELEASE&tochange=3f19dfb367d6f5418554b52997592a49a2c47f99&full=1

I’m not sure, but it is possible that 1608118 caused this issue.

Also if layers.acceleration.disabled is set to true the issue is still present.

Flags: needinfo?(maria.berlinger)
Has Regression Range: no → yes

(In reply to Maria Berlinger [:mberlinger] from comment #5)

I’m not sure, but it is possible that 1608118 caused this issue.

Seems unlikely since gum_test.html doesn't use peer connection or remove an input that I can see, but I guess we can't 100% rule out remove is called by some mistake.

You said it didn't repro in nightly, could you do a mozregression --find-fix (Search for fix: ☑) to try to find when the problem went away?

Flags: needinfo?(maria.berlinger)

Hello,
I’ve tried to ran a find fix but this issue isn’t reproducible on nightly builds. So I’ve tried to ran a find fix on beta builds but all I’ve got is this pushlog https://hg.mozilla.org/releases/mozilla-beta/pushloghtml?fromchange=484e2cc7166ccafa0f8c4afe0d42a484a1eff217&tochange=51e3079d2fee40bb9677ef14c6103fb6026176c0
I’m not sure if this helps but that’s all I’ve got.

Flags: needinfo?(maria.berlinger)
Severity: -- → S2
Priority: -- → P2

The regression dates back to 73, wontfix for 81.

This issue isn’t reproducible on nightly builds.

Hi Maria, does this still reproduce in release 83? I'm wondering if this got fixed since 82 somehow or if some nightly-only pref fixes (or hides) the problem in nightly.

Flags: needinfo?(maria.berlinger)

Hello,

I can't reproduce it on Firefox 83.0, based on that I'll mark this as works for me.

Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(maria.berlinger)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: