The Minimum label is not displayed as the selected margins option inside the new Print modal on Windows 7
Categories
(Toolkit :: Printing, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox-esr78 | --- | unaffected |
| firefox80 | --- | unaffected |
| firefox81 | --- | disabled |
| firefox82 | --- | verified |
People
(Reporter: asoncutean, Assigned: emmamalysz)
References
(Blocks 1 open bug)
Details
(Keywords: regression, Whiteboard: [print2020_v82] [old-ui-])
Attachments
(2 files)
screencast issue.gif
Affected versions
- 82.0a1
Affected platforms
- Windows 7
Steps to reproduce
- Launch Firefox
- Make sure print.tab_modal.enabled is set on true
- Open any page
- Click on More settings
- Select Minimum option from Margins dropdown
Expected result
- Minimum option is set, the print preview adjust accordingly, the label is displayed as Minimum
Actual result
- Minimum option is set, the print preview adjust accordingly, but the label remains the Default one
Regression range
- First bad: 603459fd7f347a9f5b2fb9dc52ab058188dd48d8
- Last good: 0f3afede4904a0df99f016c03dd552053560ef1b
- Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0f3afede4904a
0df99f016c03dd552053560ef1b&tochange=603459fd7f347a9f5b2fb9dc52ab058188dd48d8
Additional notes
- None is not affected by this behavior
Suggested severity
- S4 since affects only Windows 7 and the functionality is not broken
|
||
Comment 1•4 years ago
|
||
This sounds like a duplicate of bug 1662699…
|
Assignee | |
Comment 2•4 years ago
|
||
Since the marges directly from the paper and the default settings margin can return slightly
different numbers (off by .0001), we need to round in order to correctly return the minimum
value and allow the user to switch from the default preset.
|
||
Updated•4 years ago
|
|
||
Comment 3•4 years ago
•
|
||
(In reply to Emma Malysz from comment #2)
Since the marges directly from the paper and the default settings margin can return slightly
different numbers (off by .0001), we need to round in order to correctly return the minimum
value and allow the user to switch from the default preset.
Sounds like this may fix bug 1660520?
Pushed by sfoster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a98fd1750fe8 round margin values to ensure comparisons are made correctly r=sfoster
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
||
Comment 6•4 years ago
|
||
Confirming this issue no longer reproduces on Windows 7x64 using 82.0-build1, with the print.tab_modal.enabled pref set to true.
Description
•