Affected versions

• 81.0b7
• 82.0a1 (2020-09-08)

Affected platforms

• Windows 10
• Windows 7

Steps to reproduce

1. Launch Firefox
2. Make sure print.tab_modal.enabled is set on true
3. Open a long page (eg. https://ro.wikipedia.org/wiki/Albert_Einstein)
4. Set Destination to a connected printer in Portrait mode
5. Change destination to Save to pdf
6. Change Orientation to Landscape
7. Change destination to a connected printer
8. Change Orientation to Landscape

Expected result

• The Print preview is displayed in Landscape mode

Actual result

• The Print preview is displayed in Portrait mode

Regression range

• Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=93d8458a0c4dc91b24c34e2f446c76d80384c948&tochange=85e7a3055098f2f8f8d7abc59d7f0d6215e47984

Additional notes

• The issue is intermittent with a higher reproducible rate on Windows 7

Suggested severity

• S3 since it is intermittent

Following this code through the debugger after reproducing the bug it looks like the correct settings are being sent to the browser.frameLoader.printPreview() call.

I see bug 1653319 in there, perhaps this changed with the new frame loader API?

Anca, would you be able to narrow down this regression range a little? Since the settings appear to be correct bug 1653319 seems like it could be the culprit.

(In reply to Mark Striemer [:mstriemer] from comment #1)

Anca, would you be able to narrow down this regression range a little? Since the settings appear to be correct bug 1653319 seems like it could be the culprit.

• This is as far as I could go, hope is more helpful: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=886855bf6308c64ad2c459a73ba63317a8960070&tochange=47e9fdf7e93e8f3da410daa30b80b31567f3b488

Thanks, that's helpful. It looks like bug 1653319 caused this then.

Is the "Landscape" button selected when it's stuck in portrate mode? It's unclear whether the UI and the preview document are both wrong, or just the preview document.

If after carrying out steps 1-8 above it is in the wrong mode, does clicking the "Landscape", then "Portrate" then "Landscape" buttons free it up, or does it remain stuck?

Do any errors show up in Tools -> Web Developer -> Browser Console?

(In reply to Jonathan Watt [:jwatt] from comment #3)

Is the "Landscape" button selected when it's stuck in portrate mode? It's unclear whether the UI and the preview document are both wrong, or just the preview document.
If after carrying out steps 1-8 above it is in the wrong mode, does clicking the "Landscape", then "Portrate" then "Landscape" buttons free it up, or does it remain stuck?

• Only the content remains stuck in Portrait mode, the buttons are functional, toggling between them is possible, the Preparing preview is displayed for several second every time Portrait or Landscape is clicked, but the content in preview remains the same, displayed in Portrait mode regardless of witch button was last selected.
• If the modal is closed with the printer set as Destination and Landscape set as Orientation and then reopened, the print preview content is opened directly in Landscape mode, and from there on print preview takes effect at every orientation change, until the user changes again the Destination to save to pdf and then back to printer when the issue occurs once again.

Do any errors show up in Tools -> Web Developer -> Browser Console?

• No error message is displayed in console.

I can reproduce, I'll see if I can track it down.

This is to avoid the previous printer's settings object having the new printer's
name set on it.

Picked some unrelated changes by accident.

• Track user-initiated setting changes and attempt to re-apply them when switching printer
• Keep a lookup of all the paper sizes we've seen, to allow retrieving the associated width/height when attempting to match a similarly size paper in the newly selected printer
• Move the initialization of the settings for the PDF printer out of the view proxy and into resolvePropertiesForPrinter where the per-printer settings are created

https://hg.mozilla.org/mozilla-central/rev/694c9984be24

Confirming this as verified fixed this using 83.0a1(20200922154306) and 82.0b2(20200922183749) on Windows 10x64.

https://testrail.stage.mozaws.net/index.php?/cases/view/1082856