Closed Bug 1663445 Opened 4 years ago Closed 4 years ago

System dialog opens after trying to save the file with “Save to PDF” destination

Categories

(Toolkit :: Printing, defect, P2)

defect

Tracking

()

VERIFIED FIXED
83 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox81 --- disabled
firefox82 --- fixed
firefox83 --- verified
firefox84 --- verified
firefox85 --- verified

People

(Reporter: emilghitta, Assigned: sfoster)

References

(Blocks 1 open bug)

Details

(Keywords: regression, Whiteboard: [print2020_v82][old-ui-])

Attachments

(1 file)

Attached image E.gif

Affected versions

  • 82.0a1 (BuildId:20200907094115)
  • 81.0b7 (BuildId:20200906164749)

Affected platforms

  • Windows 10 64bit
  • Ubuntu 18.04 64bit
  • macOS 10.14

Preconditions

  • Perform a print via the “Save to PDF” destination in order to have the “Save to PDF” as the default set destination next time you use the print UI.

Steps to reproduce

  1. Access the following webpage.
  2. Hit CTRL + P.
  3. Change the destination from “Save to PDF” to your actual printer.
  4. Set a custom range (ex: from 2 to 3)
  5. Change the destination back to “Save to PDF”
  6. Print the file.

Expected result

  • The file is successfully printed.

Actual result

  • After clicking the “Save” button from the “Save As” prompt, the old system dialog gets open. I’ve noted that before the system dialog gets open, an empty pdf file is generated and If you try to print with the newly open system dialog it will give you an error with the following error message being outputted inside the browser console: UnknownError: Print.

Regression Window

Additional Information

  • [Suggested Severity] S2
Priority: -- → P2

Does this also affect the old print UI or only the new one?

Flags: needinfo?(emil.ghitta)

Nevermind it sounds like the new UI.

Flags: needinfo?(emil.ghitta)
Whiteboard: [print2020_v81] [old-ui-] → [print2020_v82][old-ui-]

It's possible bug 1662938 fixes this. (I couldn't reproduce even prior to that landing.)

Emil, once the fix for that bug makes it into a Nightly build, can you retest?

Flags: needinfo?(emil.ghitta)

I can still reproduce this issue using the build which contains the fix from bug 1662938.

I saw a pattern (as described in comment 0) that you need to perform a Save To PDF print first as a precondition (so that before starting the step 1 you need to have the destination automatically set to Save to PDF).

Flags: needinfo?(emil.ghitta)

Hi Bob, could you please look in to this? It seems that the patch for bug 1662938 didn't fix it.

Flags: needinfo?(bobowencode)
Severity: -- → S2

So, I think this might be related to bug 1663669.
We're overwriting the printer name in the previous printers settings at the moment, which causes some issues with the settings.
Certainly if I apply my WIP patch for that bug, it seems to fix this one.
I think sfoster is going to pick up that bug but I'll check.

Flags: needinfo?(bobowencode)
See Also: → 1663669

It looks settingsAreComplete is still false, and this causes us to show the print dialog (https://searchfox.org/mozilla-central/rev/0c97a6410ff018c22e65a0cbe4e5f2ca4581b22e/layout/printing/nsPrintJob.cpp#669-673)

(In reply to Emma Malysz from comment #7)

It looks settingsAreComplete is still false, and this causes us to show the print dialog (https://searchfox.org/mozilla-central/rev/0c97a6410ff018c22e65a0cbe4e5f2ca4581b22e/layout/printing/nsPrintJob.cpp#669-673)

That's because we were incorrectly updating the printer name.
Once we stop doing that I think this will be fixed.

Can you retest this now that bug 1663669 has landed, please.

Flags: needinfo?(emil.ghitta)

Emil is on PTO. Redirecting ni? to Vlad (see comment 10).

Flags: needinfo?(emil.ghitta) → needinfo?(vlad.lucaci)

Hello,

I have tried to reproduce this issue with 82.0a1(20200919093453) on Windows 10, Ubuntu 20 and macOS 10.14. Used the build from https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=bf7094ba8ae6fcc116bc31caf111620252af7f45, of 1663669 and was unable to encounter it anymore.

Flags: needinfo?(vlad.lucaci)

(In reply to Vlad Lucaci, QA (:vlucaci) from comment #12)

Hello,

I have tried to reproduce this issue with 82.0a1(20200919093453) on Windows 10, Ubuntu 20 and macOS 10.14. Used the build from https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=bf7094ba8ae6fcc116bc31caf111620252af7f45, of 1663669 and was unable to encounter it anymore.

Thanks, closing as FIXED by bug 1663669.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Assignee: nobody → sfoster
Depends on: 1663669
Target Milestone: --- → 83 Branch

Hello,
Confirming this issue as verified fixed on macOS 10.15 , Ubuntu 18x64 and Windows 10 with 83.0, 84.0b4 and 85.0a1(2020-11-26).
A variation of this issue has been encountered and a new ticket has been submitted 1679405

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: