Suggested severity

• S3

Affected versions

• 82.0a1 (2020-09-03)

Affected platforms

• Windows 10x64
• Windows 7x64

Preconditions

• Make sure you use this Firefox https://ftp.mozilla.org/pub/firefox/nightly/2020/08/2020-08-24-09-44-58-mozilla-central/
• Before opening the created profile copy the prefs.js into the profile folder.

Steps to reproduce

1. Install an older Firefox version
2. Go to Language from Preferences
3. Search for a language pack by using the Search dropdown (eg. French)
4. Add the language pack
5. Restart Firefox in order to apply the lang pack.
6. Update Firefox.

Expected result

• Firefox is successfully updated and is displayed in the installed langpack.

Actual result

• Firefox is successfully updated and is displayed in the installed langpack except about:preferences page.

Regression range

• I don’t think this issue is a regression since it is a feature related issue.

Additional notes

• It is possible that the issue is from the custom langpack

Did you verify the firefox version after step 5?
How did you update firefox in step 6?

Hello,

1. After step 5 we check the version of firefox with about:support. And we check the version of the langpack in about:addons (81.0b5 in this case)
2. We update from menu->about firefox-> update.

I asked in slack, but again here to record on the bug. There is a mismatch in the test plan description compared to what is tested here.

Also, was this STR attempted multiple times, did it fail 100%?

(this is a summary of my answers in the slack channel)

1. about:preferences is never translated after updating to 82.0a1.
2. about:addons is correctly translated and it shows that the language pack is updated having version 82.0a1.
3. The firefox menu is correctly translated.
4. Reproduction rate is 100%

Shane, in your experience, is it even possible to have a partially applied langpack? Since it sounds to me like the langpack is updated successfully in other places (ie, about:addons) I'm wondering if maybe about:preferences could be caching in some way here that's unrelated to langpacks.

(In reply to Daniel Cicas [:dcicas], Release QA from comment #4)

(this is a summary of my answers in the slack channel)

1. about:preferences is never translated after updating to 82.0a1.

And to confirm, this is after a page refresh? Does it get translated after a Firefox restart, or stay in a broken state?

(In reply to Rachel Tublitz [:rachel] from comment #6)

(In reply to Daniel Cicas [:dcicas], Release QA from comment #4)

(this is a summary of my answers in the slack channel)

1. about:preferences is never translated after updating to 82.0a1.

And to confirm, this is after a page refresh? Does it get translated after a Firefox restart, or stay in a broken state?

Rachel asks all the right questions - though I have a suspicion that this is startup / xul cache, so after answering her questions, and assuming the broken state persists, can you check if using about:support --> "Clear startup cache..." makes the problem go away?

Just popping in (on pto).

a) The langpack is indeed updating, as shown by looking at about:addons.

b) With nightly using the langpacks from the AMO staging server and the prefs used for testing this bug:

When installing the French langpack from AMO after startup with a new profile, I see UI change to French, but not about:preferences, it remains in English. Even a restart does not give me French in about:preferences. There may be something wrong with that langpack being used in nightly, since all I did was mess with the min/max version on the addon to test that it updates. There may also be some other changes around how we handle translations in the UI, I'm not certain on that.

So it seems we are getting partially applied langpacks on nightly, but I'm not sure why.

c) Trying the same thing on Beta and Release do not have the same behavior when installing a langpack, the UI requires a restart.

Hello,

Yes the about:preferences stays broken after a browser restart. Also using the German langpack created by Mat this issue does not occur, about:preferences is correctly translated before and after updating the browser.

If your language pack is missing FTL files, it will fall back to English (and preferences load a lot of files). Looking at console and checking which fluent strings are reported as missing might help.

I'd note that this bug doesn't have a pref.js nor a language pack, so not exactly easy to follow along.

(In reply to Francesco Lodolo [:flod] from comment #10)

I'd note that this bug doesn't have a pref.js nor a language pack, so not exactly easy to follow along.

It looks like pref.js is linked in the description for this issue. Daniel, can you confirm this is no longer an issue using the correct langpack, and we're good to close this out as invalid?

And so we have it for reference, could you attach a link to the langpack created by Mat that you're using?

Hello,

So this is the link to the german language pack that we used. With this language pack about:preferences is properly translated.

This is the french language pack Disclaimer this is not a direct link from shane, but is the only French language pack in addons-dev.allizom and it was last edited 8 days ago so im pretty sure thats the one we used.

I can confirm that using the german language pack linked above, this issue could not be reproduced.

The French langpack is missing browser/localization/fr/browser/preferences/addEngine.ftl, I expect that's causing preferences to fall back to English entirely.
https://searchfox.org/mozilla-central/source/browser/components/preferences/preferences.xhtml#41

Based on reading all the comments, this bug is due to the hacked up FR langpack, and is otherwise not a bug.