Closed Bug 1662398 Opened 4 years ago Closed 4 years ago

Page notification close button is bigger than visual indicator

Categories

(Firefox :: Messaging System, defect)

defect

Tracking

()

RESOLVED INVALID
Tracking Status
firefox-esr68 --- wontfix
firefox-esr78 --- wontfix
firefox80 --- wontfix
firefox81 --- fix-optional
firefox82 --- fix-optional

People

(Reporter: cfogel, Unassigned)

Details

(Keywords: regression)

Attachments

(1 file)

Affected versions

  • 80.0.1, 81.0b4, 82.0a1(2020-08-30);

Affected platforms

  • Windows 10, macOS 10.15, Ubuntu 18

Steps to reproduce

  1. Launch Firefox, access this link;
  2. Click anywhere in page;
  3. Hover over the close button for the notification;
  4. Click near the close button from the notification;

Expected result

  • nothing happens;

Actual result

  • button is bigger than the visual indicator for closing the notification;

Regression range

  • First bad: 2017-08-20;
  • Last good: 2017-08-19;
  • Pushlog: URL;

Additional notes

  • attached .gif to illustrate the issue;
  • same issue for the Set browser as default -close button / scenario
  • S4 suggested severity, since it's got no real impact; could be viewed as a WontFix since available area spans from the button to the right side of the notification area - useful in case of a miss-click.
Has Regression Range: --- → yes
Has STR: --- → yes
Summary: Page notification close button triggered even → Page notification close button is bigger than visual indicator

Also, since I couldn't find specs yet for this.

The [x] button would look better if it would have the same size as the one next to it.
Let me know if I should file a separate issue/enhancement for it or something is already in plan.

Component: Messaging System → PDF Viewer

This really doesn't make sense in the "PDF Viewer"-component, since this is browser functionality that live in https://searchfox.org/mozilla-central/source/toolkit/content/widgets/notificationbox.js

Most likely this is a regression from the style changes in bug 1656494.

Component: PDF Viewer → Messaging System
Regressed by: 1656494

This is intentional to provide a hit target that goes to the edge of the screen, using Fitts' Law to make the button easier to hit.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID

(In reply to Jonas Jenwald [:Snuffleupagus] from comment #2)

Most likely this is a regression from the style changes in bug 1656494.

This isn't a regression from bug 1656494. Comment #0 says that this was introduced in 2017.

No longer regressed by: 1656494
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: