Closed Bug 1662145 Opened 4 years ago Closed 4 years ago

“All” page range is invalidated if switching between a custom invalid range to “all” range

Categories

(Toolkit :: Printing, defect, P1)

Product:
Toolkit
Component:
Printing
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
82 Branch
Tracking Flags:
Tracking Status
firefox81 --- verified
firefox82 --- verified

People

(Reporter: emilghitta, Assigned: emmamalysz)

References

(Blocks 1 open bug)

Details

(Keywords: regressionwindow-wanted, Whiteboard: [print2020_v81] [old-ui-])

Attachments

(2 files)

PageRangeAll.gif
1.55 MB, image/gif
Details
Bug 1662145, make form interactable when switching to page range all and fix page count for invalid ranges
47 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review
Attached image PageRangeAll.gif —

Affected versions

  • 82.0a1 (BuildId:20200831091558)
  • 81.0b4 (BuildId:20200829200810)

Affected platforms

  • Windows 10 64bit
  • Ubuntu 20.04 64bit
  • macOS 10.14

Steps to reproduce

  1. Launch Firefox.
  2. Access the following link.
  3. Select an invalid Custom page range.
  4. Switch to “all” page range.

Expected result

  • The “all” page range is validated and the user can continue to set different printing options & to print the page.

Actual result

  • The “all” page range is invalidated and the printing options from the UI are locked.

Regression Window

  • I will search for a regression asap.

Additional Information

  • For further information regarding this issue please observe the attached screencast.
  • [Suggested Severity] S2
Whiteboard: [print2020_v81]
Whiteboard: [print2020_v81] → [print2020_v81] [old-ui-]
Assignee: nobody → emalysz

Also noticing that it flashes "42 pages" in the top, which is also incorrect

Status: NEW → ASSIGNED
Severity: -- → S2
Priority: -- → P1
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f4a3d1132b74
make form interactable when switching to page range all and fix page count for invalid ranges r=mstriemer

https://hg.mozilla.org/mozilla-central/rev/f4a3d1132b74

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox82: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch

Reminder to request Beta uplift.

Flags: needinfo?(emalysz)

Comment on attachment 9173139 [details]
Bug 1662145, make form interactable when switching to page range all and fix page count for invalid ranges

Beta/Release Uplift Approval Request

  • User impact if declined: The user will not be able to interact with the form if they enter an invalid page range and then switch to printing all
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: 1. Open Firefox
  1. Print with print.tab_modal.enabled turned on
  2. Switch to printing a custom range
  3. Put an invalid range in (e.g. something > than the number of pages)
  4. Switch back to all
  5. Notice you can interact with the form
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): No strings
  • String changes made/needed: n/a
Flags: needinfo?(emalysz)
Attachment #9173139 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9173139 [details]
Bug 1662145, make form interactable when switching to page range all and fix page count for invalid ranges

Approved for 81.0b5.

Attachment #9173139 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

This issue is verified fixed using Firefox 81.0b5 (BuildId:20200901203141) and Firefox 82.0a1 (BuildId:20200901214943) on Windows 10 64bit, macOS 10.14 & Ubuntu 18.04

Status: RESOLVED → VERIFIED
status-firefox81: fixed → verified
status-firefox82: fixed → verified
Flags: qe-verify+
Regressions: 1675483
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: