Unsupported pdf notification message larger then usual
Categories
(Firefox :: Messaging System, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox-esr78 | --- | unaffected |
firefox79 | --- | unaffected |
firefox80 | --- | unaffected |
firefox81 | --- | verified |
firefox82 | --- | verified |
People
(Reporter: bmaris, Assigned: jaws)
Details
(Keywords: regression)
Attachments
(2 files)
16.64 KB,
image/png
|
Details | |
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
Affected versions
- Firefox 81.0b2
- latest Nightly 82.0a1
Affected platforms
- Windows 10 64bit
- macOS 10.15.6
- Ubuntu 18.04 64bit
Steps to reproduce
- Start Firefox
- Visit an unsupported pdf (eg: https://www.irs.gov/pub/irs-pdf/f1040.pdf)
- Click inside the pdf
Expected result
- Notification bar is displayed letting the user know that this pdf contains form fields and is not supported.
Actual result
- Notification bar is larger then the older one. I suspect this is by design but had to be sure.
Regression range
- Potential regressor: mozregression points to bug 1656494
Additional notes
- This could be by design so this bug is mainly purposed as a clarification.
Suggested severity
- This does not apply if this is not an issue, if indeed it is I would mark it as an S3 since it's visible to the users.
Assignee | ||
Comment 1•4 years ago
•
|
||
Thanks, this is by design. If we wanted we could lower the severity of the notification so it doesn't have the yellow background. @rtestard what do you think?
Updated•4 years ago
|
Comment 2•4 years ago
|
||
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #1)
Thanks, this is by design. If we wanted we could lower the severity of the notification so it doesn't have the yellow background. @rtestard what do you think?
I'm unsure about rules for defining the severity here (please point me to it if you do know about it) but I feel like the scary yellow looking banner is not aligned with the minor functionality gaps that may exist on some pdf documents (most of them are UNKNOWN and JAVASCRIPT - if i recall well JAVASCRIPT on PDF docs are not supported in any browsers).
I'd say let's lower the severity so it looks less scary and I'll look into what it would take to disable the bar by exploring if other readers actuallyu do a better job than us.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 3•4 years ago
|
||
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bb3025c639c4 Reduce the priority of the PDF unsupported features notification since the warning one is now too distracting and PDFjs supports more features. r=Gijs
Comment 5•4 years ago
|
||
bugherder |
Assignee | ||
Comment 6•4 years ago
|
||
Comment on attachment 9173422 [details]
Bug 1661204 - Reduce the priority of the PDF unsupported features notification since the warning one is now too distracting and PDFjs supports more features.
Beta/Release Uplift Approval Request
- User impact if declined: PDF unsupported features message is too scary
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Simple 1-line change, just changes the type of the notification from warning to info
- String changes made/needed: none
Comment 7•4 years ago
|
||
Comment on attachment 9173422 [details]
Bug 1661204 - Reduce the priority of the PDF unsupported features notification since the warning one is now too distracting and PDFjs supports more features.
Approved for 81.0b6.
Comment 8•4 years ago
|
||
bugherder uplift |
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Comment 9•4 years ago
|
||
Confirmed as verified fixed on latest Nightly 82.0a1 (20200904094341) and Beta 81.0b6 (20200903205131) on Windows 10 x64bit, MacOS 10.14 and Ubuntu 18.04.4 LTS x64bit.
Updated•4 years ago
|
Description
•