Closed Bug 1655708 Opened 4 years ago Closed 4 years ago

about:telemetry's sidebar gets hidden on browser window resize

Categories

(Toolkit :: Telemetry, defect, P1)

Product:
Toolkit
Component:
Telemetry
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
81 Branch
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- wontfix
firefox79 --- wontfix
firefox80 --- wontfix
firefox81 --- verified

People

(Reporter: emilghitta, Assigned: chutten)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

aboutTelemetry.gif
1.27 MB, image/gif
Details
Bug 1655708 - about:telemetry categories have no icons r?janerik!
47 bytes, text/x-phabricator-request
Details | Review
Attached image aboutTelemetry.gif —

Affected versions

  • 81.0a1 (BuildId:20200727203201)
  • 80.0b1 (BuildId:20200727193419)
  • 79.0 (BuildId:20200720193547)
  • 78.1.0esr (BuildId:20200722151235)

Unaffected versions

  • 68.10.0esr (BuildId:20200622191537)

Affected platforms

  • Windows 10 64bit
  • Ubuntu 18.04 64bit
  • macOS 10.14

Steps to reproduce

  1. Launch Firefox.
  2. Access the about:telemetry page.
  3. Reduce the browser window width.

Expected result

  • All about:telemetry elements are responsive to the browser window width change and are successfully visible.

Actual result

  • The about:telemetry sidebar becomes hidden if the browser window width is reduced.

Regression Range

Notes

  • For further information regarding this issue please observe the attached screencast.
  • [Suggested Severity] I would recommend marking this as S4 since this is a cosmetic issue.
  • Please feel free to change the component if this doesn't fit here.

Hi Mark!

It seems that mozregression pointed out Bug 1525178 - Part 6: Change about:addons category on keyboard nav r=rpl for causing this regression.

I'm not sure about the result since your patch targeted the about:addons page.

Could you please take a look?

Thank you!

Flags: needinfo?(mstriemer)
Has Regression Range: --- → yes
Has STR: --- → yes

Yes, that but is likely what caused this. It would've been the Bug 1525178 - Part 3: Add second about:addons sidebar in HTML change which would've regressed this.

Adding the category-no-icon class to each category without an icon should fix it.

Flags: needinfo?(mstriemer)
Assignee: nobody → chutten
Severity: -- → S4
Status: NEW → ASSIGNED
Priority: -- → P1

This will ensure that the don't disappear when the window gets narrow.

Also, I've tweaked some styles so the spacing works better without icons.

Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/51d62a946a24
about:telemetry categories have no icons r=janerik

https://hg.mozilla.org/mozilla-central/rev/51d62a946a24

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox81: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch

The patch landed in nightly and beta is affected.
:chutten, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(chutten)

This issue is verified fixed using Firefox 81.0a1 (BuildId:20200802214843) on Windows 10 64bit, macOS 10.14 and Ubuntu 18.04 64bit

Status: RESOLVED → VERIFIED
status-firefox81: fixed → verified
status-firefox80: affected → wontfix
Flags: needinfo?(chutten)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: