Suggested severity

• S2

Affected versions

• Fx80.0b1
• Fx81.0a1

Affected platforms

• Windows 10
• Windows 7
• Ubuntu 18.04

Steps to reproduce

1. Launch Firefox with a fresh profile.
2. Visit http://example.com, http://www.example.com, https://example.com, and https://www.example.com, in that order, in the same tab.
3. Open a new tab and close the tab that you were opening example.com in.
4. Type "ex" in the address bar.

Expected result
*The first result (the one that would be selected if you hit Enter), is https://www.example.com.

Actual result

• The selected link is http://www.example.com (the unsecured version of the link).

Regression range

• Will come back with a regression ASAP, but from the look of it, something broke between Fx79.0b9 and Fx80.0b1, because the issue does not occur in the release version.

[Tracking Requested - why for this release]: We may not be picking the best protocol for autofill

These all end up with the same score (since they are all visited the same way and none is bookmarked), causing us to pick the prefix in db order rather than "the last inserted" like we used to.
Ideally it would be better if we'd pick the secure one... but while keeping the old behavior is simple, I'm not yet sure how complex is to pick https. I'll check.

https://hg.mozilla.org/mozilla-central/rev/e934784933a9

Please request uplift to beta when you get a chance.

Comment on attachment 9166606 [details]
Bug 1655693 - In case of score match, autofill should prefer https. r=adw

Beta/Release Uplift Approval Request

• User impact if declined: We may not pick the best protocol in autofill when there's a score match, we should prefer https.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: The bug was filed by QA with good STR.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This breaks down an existing order by, so it will act only when multiple entries have the same score, thus its reach is limited. It has an automated test.
• String changes made/needed:

Comment on attachment 9166606 [details]
Bug 1655693 - In case of score match, autofill should prefer https. r=adw

approved for 80.0b3

https://hg.mozilla.org/releases/mozilla-beta/rev/b36d26086820

Reproduced the issue in version 81.0a1 2020-07-28, then verified the fix:

with
81.0a1 2020-08-11
80.0b6 2020-08-07

on

Windows 10
Ubuntu 20