Affected versions

• 80.0b1

Affected platforms

• Windows 10;

Steps to reproduce

1. Launch Netflix and login with a valid account;
2. Access the Latest or any section;
3. Hover over movie tiles to trigger the trailer video;

Expected result

• PIP not displayed on trailer;

Actual result

• PIP displayed;

Regression range

• will check and provide one asap, fwiw it appears to be limited to 80.0b1;

Additional notes

• the report is for tiles appearing in the home-screens not the movie its self;
• attached screenshot with the issue;
• 81.0a1 (2020-07-27) not affected.

Probably not a regression, it looks like we're just hiding it for /browse, not /latest:

https://searchfox.org/mozilla-central/source/browser/extensions/webcompat/data/picture_in_picture_overrides.js#32

Christian, are you able to reproduce this on a /browse page, or only /latest?

Confirmed it on all the main sections (landing, browse, latest, my list).

(In reply to Cristian Fogel, QA [:cfogel] from comment #2)

Confirmed it on all the main sections (landing, browse, latest, my list).

So this is confusing, it should be blocked on /browse per comment #1. Can you please find a regression window?

Sure, looked in to it and got some additional details:

• it's not limited to Win10, just managed to reproduce on macOS 10.15 as well;
• 78.0.2, 79.0, 81.0a1(2020-08-04) are also affected by this issue, so it's not limited just to the beta branch;
• not a regression;
• visible with addition of pip-toggle button addition @ 2019-april (04-07), mozregression threw some errors before I could get the actual date;
• looking at the account details, in our documents; the account in cause is noted as being in romanian(language-wise) which brings a tought to mind, that it might be related to non en-US accounts.

Mike, do you know what's going on here? I'm a little bit lost and don't have a netflix account. But I don't understand why we'd display the toggle if we have explicit URL-based code to disable that, unless all of that code is broken, which seems unlikely...

I suspect this is similar to bug 1653265. I think this is being caused by bug 1605527, where sites that use the history API to "navigate" the user don't have toggle policies re-evaluated.

In the case of this bug, I suspect that cfogel started on a page where the toggle was allowed, and then by clicking on the links to get to browse, etc, the "allow" policy was applied.

I believe by fixing bug 1605527 we can solve this.

Bug 1605527 is closed, so the weird issue where the toggle appears on all Netflix pages depending on where you enter the application from should be fixed.

I think the way to fix the original bug here is to add /latest to the policy set. Does this sound good, miketaylr?

Since I forgot to add it in the initial comment, after looking at it;
The suggested severity revolves around S2/S3 since it's not respecting the intended specs.

(In reply to Mike Conley (:mconley) (:⚙️) from comment #7)

Bug 1605527 is closed, so the weird issue where the toggle appears on all Netflix pages depending on where you enter the application from should be fixed.

I think the way to fix the original bug here is to add /latest to the policy set. Does this sound good, miketaylr?

Yep, that sounds right to me. We'll fix this in v15.

Fixed with the in the parent bug (https://bugzilla.mozilla.org/attachment.cgi?id=9175540).

@Thomas, from what I can see 82.0b1, 83.0a1 (2020-09-21) still presents the reported issue; just confirmed it on Windows10/macOS11.0.

Thanks cfogel, I've filed bug 1666561 about this.

(In reply to Cristian Fogel, QA [:cfogel] from comment #11)

@Thomas, from what I can see 82.0b1, 83.0a1 (2020-09-21) still presents the reported issue; just confirmed it on Windows10/macOS11.0.

This is unexpected. Can you tell me what preferences you have set under media.videocontrols.picture-in-picture.video-toggle in about:config? If you set media.videocontrols.picture-in-picture.video-toggle.mode to -1, are you still able to reproduce the issue?

Listing all the prefs under that section, this being the case for fresh/new profiles as well:
media.videocontrols.picture-in-picture.video-toggle.always-show -- false
media.videocontrols.picture-in-picture.video-toggle.enabled -- true
media.videocontrols.picture-in-picture.video-toggle.has-used --- false
media.videocontrols.picture-in-picture.video-toggle.min-video-secs -- 45
media.videocontrols.picture-in-picture.video-toggle.mode -- 2
media.videocontrols.picture-in-picture.video-toggle.position -- right
services.sync.prefs.sync.media.videocontrols.picture-in-picture.video-toggle.enabled -- true

Setting media.videocontrols.picture-in-picture.video-toggle.mode to -1 shows PIP button as well, however it's the old(blue) design.

(In reply to Cristian Fogel, QA [:cfogel] from comment #14)

Setting media.videocontrols.picture-in-picture.video-toggle.mode to -1 shows PIP button as well, however it's the old(blue) design.

What is the URL of the page you're on when you reproduce this?

Button shows for some videos in these sections: shows, movies, my page.
[Main-page] and [latest] section appear to work just fine and not display the PIP button.