Closed
Bug 1655412
Opened 4 years ago
Closed 3 years ago
NetMonitor - Center icon in [Start performance analysis] button
Categories
(DevTools :: Netmonitor, defect, P2)
Tracking
(firefox-esr78 wontfix, firefox79 wontfix, firefox80 wontfix, firefox85 wontfix, firefox86 wontfix, firefox87 fixed)
RESOLVED
FIXED
87 Branch
People
(Reporter: cfogel, Assigned: sebo)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: polish, regression)
Attachments
(2 files)
Affected versions
- 80.0a1(2020-07-23), 79.0b9;
Affected platforms
- Windows 10, macOS 10.15, Ubuntu 18;
Steps to reproduce
- Launch Firefox, open any webpage;
- enable Devtools - Network Monitor tab;
- Observe the bottom-left button;
Expected result
- icon centered in button;
Actual result
- icon is clamped to bottom side of button;
Regression range
- considering as good part of the range the last changes to the button; where the icon was on the top-side of the button(it still not being center-ed); prior to this the icon was center-ed - with a different icon;
- First bad: 2020-05-13;
- Last good: 2020-05-12;
- Pushlog: URL;
Additional notes
- attached screenshot with the issue;
- S4 as suggested severity.
Reporter | ||
Updated•4 years ago
|
Updated•4 years ago
|
Type: enhancement → defect
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
Updated•3 years ago
|
Assignee: nobody → sebastianzartner
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•3 years ago
|
||
To be precise, the change was caused by https://hg.mozilla.org/mozilla-central/rev/bd0638c0c5579bef09253122984544287bb8ce67. I've now made the button two pixels higher to get a little padding around the icon and vertically centered it.
Sebastian
Pushed by sebastianzartner@gmail.com: https://hg.mozilla.org/integration/autoland/rev/fed9ba840375 Vertically centered 'Start performance analysis' button in Network Monitor. r=ladybenko
Comment 4•3 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox87:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
Updated•3 years ago
|
status-firefox85:
--- → wontfix
status-firefox86:
--- → wontfix
status-firefox-esr78:
--- → wontfix
Regressed by: 1634380
Updated•3 years ago
|
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•