Closed Bug 1655406 Opened 4 years ago Closed 4 years ago

Empty context menu if enter is pressed to fast on a letter

Categories

(DevTools :: Console, defect)

Product:
DevTools
Component:
Console
Platform:
Desktop
All
Type:
defect

Tracking

(firefox-esr68 unaffected, firefox-esr78 wontfix, firefox78 wontfix, firefox79 wontfix, firefox80 wontfix, firefox81 verified)

Status:
VERIFIED FIXED
Milestone:
81 Branch
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- wontfix
firefox78 --- wontfix
firefox79 --- wontfix
firefox80 --- wontfix
firefox81 --- verified

People

(Reporter: atrif, Assigned: nchevobbe)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

emty_context.gif
70.32 KB, image/gif
Details
Bug 1655406 - Fix race condition when hitting Enter. r=Honza.
47 bytes, text/x-phabricator-request
Details | Review
Attached image emty_context.gif —

Affected versions

  • 80.0a1 (20200726214746)
  • 79.0 (20200720193547)
  • 78.0.2 (20200708170202)
  • 78.1.0esr (20200722151235)

Affected platforms

  • Windows 10x64
  • macOs 10.12
  • Ubuntu 18.04

Steps to reproduce

  1. Open Firefox web console.
  2. Type a random letter (e.g a) and press Enter.

Expected result

  • Context menu is no longer shown.

Actual result

  • Blank context menu is displayed.

Regression range

Notes

  • Attached a screen recording.
  • Note that the issue may require several times to reproduce due to timing.

Severity S3

Has Regression Range: --- → yes
Has STR: --- → yes

The severity field is not set for this bug.
:nchevobbe, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(nchevobbe)
Severity: -- → S3
Flags: needinfo?(nchevobbe)

Sometimes, it might happen that the user triggered the popup
opening (by typing a letter) and hit Enter before the popup
was already shown, which would result in a blank popup being opened.
This patch addresses that by storing the popup opening promise
and if it exists in the code that handle the Enter key, wait until
the promise resolves and hide the popup.

It would be tricky to write a consistent test as this race is depending
on the server response time and the time it take for the popup to be
shown; but manual tests seemed to indicate this fixes the issue.

Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2c15c7f0d3c6
Fix race condition when hitting Enter. r=Honza.

https://hg.mozilla.org/mozilla-central/rev/2c15c7f0d3c6

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox81: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
Flags: qe-verify+

Reproduced the issue with Firefox 81.0a1 (20200727203201) on Windows 10x64.
The issue is verified fixed with Firefox 81.0b8 (20200908191057) on Windows 10x64, macOS 10.12 and Ubuntu 18.04.

Status: RESOLVED → VERIFIED
status-firefox81: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: