Closed Bug 1655402 Opened 4 years ago Closed 4 years ago

Reader mode toolbar black residual bar near focussed buttons

Categories

(Toolkit :: Reader Mode, defect, P3)

Unspecified
All
defect

Tracking

()

VERIFIED FIXED
81 Branch
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- wontfix
firefox78 --- wontfix
firefox79 --- wontfix
firefox80 --- wontfix
firefox81 --- verified

People

(Reporter: cfogel, Assigned: jaws)

References

Details

(Keywords: regression)

Attachments

(2 files)

Affected versions

  • 78.0.2, 79.0b9, 80.0a1(2020-07-23)

Affected platforms

  • Windows 10, macOS 10.15.6;

Steps to reproduce

  1. Launch Firefox and access any link that has reader-mode support. ex: link;
  2. Click on the Reader Mode button to enable it;
  3. Click on the [Aa] button;
  4. TAB navigate around the other options;

Expected result

  • selector properly displayed on active elements;

Actual result

  • near the ReaderMode controllers, a black line appears in the right-side of the buttons;

Regression range

  • First bad: 2020-05-23;
  • Last good: 2020-05-22;
  • Pushlog: URL;
  • appeared with changes to the UI/controllers being moved to the inner-page position;

Additional notes

  • attached recording with the issue;
  • S4 as suggested severity.
Has Regression Range: --- → yes
Has STR: --- → yes
Keywords: regression

The regression range is a bit misleading because the sidebar was implemented, then the UI changed to have a top bar, and then on this date range the top bar was reverted back to a sidebar (bug 1637652).

The dark part that you're seeing is actually a hover label for the button. It doesn't have high enough z-index to be visible above the popup. I'll attach a patch.

Assignee: nobody → jaws
Status: NEW → ASSIGNED
Severity: -- → S3
Priority: -- → P3
Attachment #9167716 - Attachment description: Bug 1655402 - Show hover-label above the reader mode settings popup. r?Gijs → Bug 1655402 - Don't show the hover-label if a popup is open. r?Gijs
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f87ba534a2fb
Don't show the hover-label if a popup is open. r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
Flags: qe-verify+

Reproduced the issue with Firefox 81.0a1 (20200727203201) on Windows 10x64.
The issue is verified fixed with Firefox 81.0b8 (20200908191057) on Windows 10x64, macOS 10.12 and Ubuntu 18.04.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Regressions: 1669112
Blocks: 1642510
Regressions: 1680604
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: