Closed Bug 1654731 Opened 4 years ago Closed 2 years ago

Preview class when selecting item in the cls autocomplete popup

Categories

(DevTools :: Inspector: Rules, enhancement)

Product:
DevTools
Component:
Inspector: Rules
Type:
enhancement

Tracking

(firefox101 fixed)

Status:
RESOLVED FIXED
Milestone:
101 Branch
Tracking Flags:
Tracking Status
firefox101 --- fixed

People

(Reporter: nchevobbe, Assigned: rfemailtesting, NeedInfo)

References

Details

(Keywords: parity-chrome)

Attachments

(1 file, 1 obsolete file)

Bug 1654731 - [devtools] Preview class when selecting item in the cls autocomplete popup r?jdescottes
48 bytes, text/x-phabricator-request
Details | Review

It would be nice if, like in Chrome, browsing through the autocomplete results, the selected class in the popup would be previewed on screen.

Assignee: nobody → rfemailtesting
Status: NEW → ASSIGNED

sorry I just wanted to modify my commit message, by amending the message of the existing commit, but it seems like it created a new patch 🙈😅

Attachment #9252663 - Attachment is obsolete: true
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e8a9d431ea18
[devtools] Preview class when selecting item in the cls autocomplete popup r=jdescottes

Backed out for devtools failures on browser_rules_class_panel_add.js.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&revision=e8a9d431ea181823d76e2f1a40dca5e5c9121de2&searchStr=dt&selectedTaskRun=XWHod6PLTteI20DXhJIjpQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=375548486&repo=autoland
https://treeherder.mozilla.org/logviewer?job_id=375547245&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/50a4681fa779d8e5a77803ef65a865b22b79fd40

[task 2022-04-23T11:49:26.499Z] 11:49:26     INFO - TEST-PASS | devtools/client/inspector/rules/test/browser_rules_class_panel_add.js | Success: untitled - 
[task 2022-04-23T11:49:26.499Z] 11:49:26     INFO - Check the state of the DOM node
[task 2022-04-23T11:49:26.500Z] 11:49:26     INFO - Buffered messages finished
[task 2022-04-23T11:49:26.501Z] 11:49:26     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/rules/test/browser_rules_class_panel_add.js | The DOM node has the right className - Got "class a clas class2 class3", expected "class a class2 class3"
[task 2022-04-23T11:49:26.502Z] 11:49:26     INFO - Stack trace:
[task 2022-04-23T11:49:26.502Z] 11:49:26     INFO - chrome://mochikit/content/browser-test.js:test_is:1422
[task 2022-04-23T11:49:26.503Z] 11:49:26     INFO - chrome://mochitests/content/browser/devtools/client/inspector/rules/test/browser_rules_class_panel_add.js:null:102
[task 2022-04-23T11:49:26.503Z] 11:49:26     INFO - chrome://mochikit/content/browser-test.js:handleTask:989
[task 2022-04-23T11:49:26.503Z] 11:49:26     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1061
[task 2022-04-23T11:49:26.504Z] 11:49:26     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1189
[task 2022-04-23T11:49:26.504Z] 11:49:26     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:978
[task 2022-04-23T11:49:26.505Z] 11:49:26     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1041
[task 2022-04-23T11:49:26.506Z] 11:49:26     INFO - Check the content of the class panel
[task 2022-04-23T11:49:26.506Z] 11:49:26     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-04-23T11:49:26.508Z] 11:49:26     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/rules/test/browser_rules_class_panel_add.js | The panel contains the expected number of checkboxes - Got 5, expected 4
[task 2022-04-23T11:49:26.508Z] 11:49:26     INFO - Stack trace:
[task 2022-04-23T11:49:26.509Z] 11:49:26     INFO - chrome://mochikit/content/browser-test.js:test_is:1422
[task 2022-04-23T11:49:26.509Z] 11:49:26     INFO - chrome://mochitests/content/browser/devtools/client/inspector/rules/test/head.js:checkClassPanelContent:647
[task 2022-04-23T11:49:26.510Z] 11:49:26     INFO - chrome://mochitests/content/browser/devtools/client/inspector/rules/test/browser_rules_class_panel_add.js:null:105
[task 2022-04-23T11:49:26.510Z] 11:49:26     INFO - chrome://mochikit/content/browser-test.js:handleTask:989
[task 2022-04-23T11:49:26.511Z] 11:49:26     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1061
[task 2022-04-23T11:49:26.511Z] 11:49:26     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1189
[task 2022-04-23T11:49:26.511Z] 11:49:26     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:978
[task 2022-04-23T11:49:26.512Z] 11:49:26     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1041
[task 2022-04-23T11:49:26.513Z] 11:49:26     INFO - TEST-PASS | devtools/client/inspector/rules/test/browser_rules_class_panel_add.js | Checkbox 0 has the right class name -
Flags: needinfo?(rfemailtesting)
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cdc42b7822f1
[devtools] Preview class when selecting item in the cls autocomplete popup r=jdescottes

https://hg.mozilla.org/mozilla-central/rev/cdc42b7822f1

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox101: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: