Closed Bug 1654484 Opened 4 years ago Closed 4 years ago

[Ubuntu] Print Preview is refreshed after closing Page Setup prompt

Categories

(Core :: Print Preview, defect)

Product:
Core
Component:
Print Preview
Platform:
Desktop
Linux
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
81 Branch
Tracking Flags:
Tracking Status
firefox78 --- wontfix
firefox79 --- wontfix
firefox80 --- wontfix
firefox81 --- fixed

People

(Reporter: vlucaci, Assigned: jfkthame)

Details

Attachments

(2 files)

vokoscreen-2020-07-22_12-06-26.mkv
3.78 MB, video/x-matroska
Details
Bug 1654484 - Don't regenerate print preview on Linux if Page Setup dialog is opened but cancelled or closed without changes. r=jwatt
47 bytes, text/x-phabricator-request
Details | Review

Affected versions

  • 68.11.0esr
  • 80.0a1(2020-07-21)

Affected platforms

  • Ubuntu 18.04

Steps to reproduce

  1. Launch FF.
  2. Go to www.pdf995.com/samples/pdf.pdf.
  3. Print preview the page.
  4. Go to Page Setup...
  5. Press Escape.

Expected result

  • The Page Setup prompt is closed without any issues.

Actual result

  • Closing the Page Setup prompt renders the whole Print Preview to be refreshed.

Regression range

  • I went as far back as builds from 2016-04-04 and the issue occurs with the same repro steps. I do not think that this is a regression.

Additional notes

  • In order of consistency, the same behavior should be kept as for the Print... prompt from Print Preview.
  • Seeing as how it would only be a nuisance for users who scroll a document, then lose the position when closing the Page Setup... prompt, I would consider this issue an S3.

If Page Setup settings are changed, we currently completely regenerate the print preview (bug 1653340 should make it possible to improve this).

However, in this case it sounds like we're doing that even if Page Setup was cancelled, making no changes. That seems like a bug in its own right; if the Page Setup dialog is cancelled, we shouldn't need to recreate or update the preview at all.

Severity: -- → S3

Vlad, have you checked if this also occurs on Windows, or is it specific to Linux only?

Flags: needinfo?(vlad.lucaci)

Hello Jonathan,

Yes, I have tried it on Windows as well and this issue is not present.
For Windows, print preview regenerates only if changes are made.

Flags: needinfo?(vlad.lucaci)

It appears the gtk_print_run_page_setup_dialog function just doesn't return any indication of whether the user cancelled or confirmed the dialog.

So to check whether we need to regenerate the preview, we can do things the hard way: compare the old and new settings, and bail out without refreshing the preview if they're identical.

Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Has STR: --- → yes
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0ddd8e15aa4e
Don't regenerate print preview on Linux if Page Setup dialog is opened but cancelled or closed without changes. r=jwatt

https://hg.mozilla.org/mozilla-central/rev/0ddd8e15aa4e

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox81: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch

The patch landed in nightly and beta is affected.
:jfkthame, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(jfkthame)

This is basically a cosmetic issue and has been around a long time; it can just ride the train.

status-firefox80: affected → wontfix
Flags: needinfo?(jfkthame)
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: