Closed Bug 1654246 Opened 4 years ago Closed 4 years ago

A previously removed default search engine is not restorable after a browser restart/upgrade

Categories

(Firefox :: Search, defect, P1)

Product:
Firefox
Component:
Search
Version:
80 Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 80
Iteration:
80.2 - July 13 - July 26
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox78 --- unaffected
firefox79 --- unaffected
firefox80 --- verified

People

(Reporter: emilghitta, Assigned: standard8)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

RemoveSearchEngine.gif
938.00 KB, image/gif
Details
Bug 1654246 - When cloning search engines for preferences, clone the hidden property as well to ensure restore default engines works correctly. r?daleharvey!
47 bytes, text/x-phabricator-request
Details | Review
Attached image RemoveSearchEngine.gif —

Affected versions

  • 80.0a1 (BuildId:20200720214226)

Unaffected versions

  • 79.0b9 (BuildId:20200717001501)
  • 79.0 (BuildId:20200720193547)
  • 78.0.2 (BuilId:20200708170202)
  • 68.10.0esr (BuildId:20200622191537)
  • 78.0.2esr (BuildId:20200708170510)

Affected platforms

  • Windows 10 64bit
  • Ubuntu 18.04 64bit
  • macOS 10.14

Steps to reproduce

  1. Launch Firefox.
  2. Access the about:preferences#search page.
  3. Remove a default search engine.
  4. Restart Firefox or upgrade Firefox.
  5. Access the about:preferences#search page.
  6. Try restoring the default search engines by clicking the “Restore Defaults Search Engine” button.

Expected result

  • The “Restore Default Search Engine” button is enabled and the search engine can be successfully restored.

Actual result

  • The “Restore Default Search Engine” button is disabled and the previously removed search engine cannot be successfully restored.

Regression Range

Notes

  • For further information regarding this issue please observe the attached screencast.
  • A workaround for this issue is to remove another search engine (during the same browser session) and restore them all by clicking the “Restore Default Search Engine”
  • Same issue is encountered if trying to reorder the search engines, after a browser restart their default position cannot be restored via the "Restore Default Search Engine" button.
  • [Proposed Severity] I think that this is a S3 severity issue.

Hi Mark!

It seems that mozregression pointed out Bug 1647359 - Move SearchEngine fields to start of class for better clarity and documentation. r=daleharvey for causing this regression.

Can you please take a look?

Thank you!

Flags: needinfo?(standard8)

Thanks for finding this and the heads up. I see the issue, I'll get a patch up soon.

Assignee: nobody → standard8
Severity: -- → S2
Status: NEW → ASSIGNED
Iteration: --- → 80.2 - July 13 - July 26
Flags: needinfo?(standard8)
Priority: -- → P1
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7f9dda850e84
When cloning search engines for preferences, clone the hidden property as well to ensure restore default engines works correctly. r=daleharvey,preferences-reviewers,ntim

https://hg.mozilla.org/mozilla-central/rev/7f9dda850e84

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox80: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 80

This issue is verified fixed using Firefox 80.0b1 (BuildId:20200727193419) on Windows 10 64bit, macOS 10.14 and Ubuntu 18.04 64bit.

Status: RESOLVED → VERIFIED
status-firefox80: fixed → verified
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: