Closed Bug 1653961 Opened 4 years ago Closed 4 years ago

Print preview -> Print/Save of multiple tabbed documents shows the name from the previously printed tab

Categories

(Core :: Print Preview, defect, P2)

80 Branch
Unspecified
All
defect

Tracking

()

VERIFIED FIXED
mozilla80
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox79 --- unaffected
firefox80 --- verified

People

(Reporter: cfogel, Assigned: jwatt)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [print2020_v80])

Attachments

(2 files)

Affected versions

  • 80.0a1(20200719185002)

Affected platforms

  • Ubuntu 18, Windows 10(ARM)

Steps to reproduce

  1. Launch Firefox, access 2 websites in different tabs; ex: link1 - tab1, link 2 - tab2;
  2. In tab1 Click on the Hamburger menu -> click Print;
  3. Can pick to print either to File or Printer - irrelevant which option; // save-print file & preview can be closed after printing/saving ;
  4. In tab2 Click on the Hamburger menu -> click Print;
  5. Repeat step 3;
  6. In tab1 press CTRL+P to trigger print;
  7. Save/print file

Expected result

  • each file/header is the same as the page printed/saved

Actual result

  • tab1 has file-name from tab2;
  • file-name of what is sent to print is same as in tab2;
  • other than that, the print is not affected;

Regression range

  • First bad: 2020-07-06
  • Last good: 2020-07-05
  • Pushlog: URL
  • Potential regressor: 1636803

Additional notes

  • attached snapshot with the issue, top-right - observe the name of the file printed (random page instead of it being "CSS test pages";
  • suggested severity - S3 due to the impact in certain domains;
  • print-to file doesn't always need to be between the both tabs, issue reproduced as well with print-to-file of tab1 then print of tab2(steps above being more reliable).

@Jwatt, when you have time; could you confirm the regression range being accurate?
Thank you!

Has Regression Range: --- → yes
Has STR: --- → yes
Flags: needinfo?(jwatt)

It is not possible to open print preview for two tabs in the same window, since as soon as you open print preview for one tab then all the other tabs are hidden. Can you clarify - did you mean you're doing this is separate windows?

Flags: needinfo?(jwatt) → needinfo?(cristian.fogel)

Oh, I see what you mean. You finished printing for the first tab and closed print preview before opening it in the second.

Flags: needinfo?(cristian.fogel)
Assignee: nobody → jwatt
Priority: -- → P2
Whiteboard: [print2020_v80]

The _originalURL/_originalTitle properties are used during print preview to
work around the simplified-mode doc losing the URL/title of the original
document. This change makes us clear those properties when print preview exits
so that a previously previewed documents title/URL doesn't "leak" to the next
document. It also fixes printWindow() to not assume these properties exist,
since if the print was invoked directly (not via print preview) they will not
have been set.

Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/autoland/rev/e69e85ff0c7e
Stop previous printed doc's title/URL being used for the next doc. r=Gijs
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80

Verified with 80.0a1(2020-07-26).

Status: RESOLVED → VERIFIED
Blocks: 1587459
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: