Closed
Bug 1653946
Opened 4 years ago
Closed 4 years ago
[Windows] Show all the bookmarks folder/ Show all tags expand arrows are barely visible on dark theme
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 80
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox-esr78 | --- | unaffected |
| firefox78 | --- | unaffected |
| firefox79 | --- | wontfix |
| firefox80 | --- | verified |
People
(Reporter: asoncutean, Assigned: itiel_yn8)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
|
7.56 KB,
image/png
|
Details | |
|
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-release-
|
Details | Review |
screenshot issue.png
Affected versions
- 79.0b9
- 80.0a1 (2020-07-19)
Affected platforms
- Windows 10
Steps to reproduce
- Set Firefox on dark theme (Menu - Customize - Themes)
- Attempt to bookmark any website
- Observe the Show all the bookmarks folder/ Show all tags arrows
Actual result
- The down arrows are barely visible
Expected result
- The down arrows are visible
Regression range
- Last good revision: b8042315fdd5b989c6c376f5af8ab45f83a6d694
- First bad revision: cde514af53487c2a0903c290456c970869a301a3
- Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b8042315fdd5b989c6c376f5af8ab45f83a6d694&tochange=cde514af53487c2a0903c290456c970869a301a3
Additional notes
- Not reproducible on Ubuntu 18 and macOS 10.15
- Recommended severity: S3
|
Reporter | |
Updated•4 years ago
|
Has Regression Range: --- → yes
Has STR: --- → yes
|
||
Updated•4 years ago
|
Component: Bookmarks & History → Theme
Assignee: nobody → itiel_yn8
Status: NEW → ASSIGNED
Flags: needinfo?(itiel_yn8)
|
||
Updated•4 years ago
|
Flags: qe-verify+
|
|
||
Comment 2•4 years ago
|
||
Comment on attachment 9164774 [details]
Bug 1653946 - Fix the expander icons visibility in dark mode r?dao
Beta/Release Uplift Approval Request
- User impact if declined: See comment 0
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: Steps in comment 0
- List of other uplifts needed: -
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Trivial removal of broken CSS
- String changes made/needed: -
Attachment #9164774 -
Flags: approval-mozilla-beta?
|
||
Comment 3•4 years ago
|
||
Comment on attachment 9164774 [details]
Bug 1653946 - Fix the expander icons visibility in dark mode r?dao
79 is on release now, moving the request over in case of an RC respin.
Attachment #9164774 -
Flags: approval-mozilla-beta? → approval-mozilla-release?
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/46e7489b7a51 Fix the expander icons visibility in dark mode r=dao
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 80
|
||
Updated•4 years ago
|
QA Whiteboard: [qa-triaged]
|
|
Reporter | |
Comment 6•4 years ago
|
||
I can confirm the fix with Fx 80.0a1 (2020-07-22) on Windows 10.
|
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
|
||
Comment 7•4 years ago
|
||
Comment on attachment 9164774 [details]
Bug 1653946 - Fix the expander icons visibility in dark mode r?dao
80 ships next week, and there are no plans for a 79 dot release
Attachment #9164774 -
Flags: approval-mozilla-release? → approval-mozilla-release-
You need to log in
before you can comment on or make changes to this bug.
Description
•