[Ubuntu] About Firefox dialog can be maximized / resized
Categories
(Firefox :: General, defect, P5)
Tracking
()
People
(Reporter: vlucaci, Unassigned)
References
Details
Attachments
(1 file)
|
66.70 KB,
image/jpeg
|
Details |
maximize about.JPG
Affected versions
- 78.0.2
- 79.0b9
- 80.0a1 (2020-07-16)
Affected platforms
- Ubuntu 18.04x64
Steps to reproduce
- Launch FF.
- Go to the burger menu.
- Go to Help.
- Go to About FF/Nightly.
- Press the maximize button.
Expected result
- Maximize button is greyed out and user cannot interact with this option.
Actual result
- Maximize button is greyed out but the user can interact with this option and make the About prompt full screen, leaving half a screen blank .
Regression range
- I went as far back as builds from 2016 and managed to reproduce this issue with the same repro steps. This does not seem like a regression.
Additional notes
- Seeing as how both macOS and Windows opt out for that option, it would be good if consistency were kept for Ubuntu as well.
- I would consider this issue an S3.
- This issue may have caused 1535592.
|
Reporter | |
Updated•4 years ago
|
|
||
Comment 1•4 years ago
|
||
AFAICT this is a result of setting dialog=no, which changed in bug 608934, 10 years ago, in utilityOverlay.js when this dialog is opened ( https://searchfox.org/mozilla-central/rev/b2395478c6adf6e5b241be1610fb1d920ed995ed/browser/base/content/utilityOverlay.js#974,977 ).
I agree that ideally the dialog should not be maximizable/resizable. Karl, you commented in that bug about how you think the dialog should work. Is there a way to achieve the dialog being minimizable but not resizable on GTK? Setting resizable=no seems to have no effect, if my quick test is anything to go by.
|
||
Comment 2•4 years ago
|
||
What is the problem with allowing the window to be resized?
I'm sure there are better ways to address the white bar shown here.
gdk_window_set_functions() was an API with the purpose of hinting about buttons on the window frame, but "few window managers do anything reliable or interesting with this hint".
I don't know how resizable=no is implemented or not.
For windows that must not change size, SetSizeConstraints() is available.
Please ensure to avoid getting into situations often seen on WINNT where unnecessary scrolling is required to see the information available.
What would happen on a small display in portrait orientation, for example?
Dialogs can be resizable, but this window is still not a dialog, as it is a one-way conversation.
Description
•