Affected versions

• 78.0, 79.0a1

Affected platforms

• macOS 10.15.5, Windows 10, Ubuntu 16;

Steps to reproduce
Following setup:

• "extensions.formautofill.available" change it from "detect" to "on"
• "browser.search.region" change to "US"
• in about:preferences#privacy click on Saved Addresses and add at least 1 new adress;

Steps:

1. Launch Firefox and access this link;
2. Double click on any field and select any dataset from the list;
3. Change the value for any auto-filled section;
4. Click on the Submit button from the webpage;

Expected result

• message pop-up properly displayed;

Actual result

• message pop-up appears to lack the icon in front of the message;

Regression range

• First bad: 2020-02-27
• Last good: 2020-02-26
• Pushlog: URL;

Additional notes

• attached screenshot with the issue;
• suggested severity is between S3/S4, due to the image lacking from a menu that isn't encountered as often by user.

Possibly a regression from bug 1618203.

Comment on attachment 9160079 [details]
Bug 1648417 - Fix the doorhanger icon for updating an autofilled form r?MattN

Beta/Release Uplift Approval Request

• User impact if declined: An icon won't be shown in the address autofill save doorhanger
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple mismatch/typo fix in a .svg file
• String changes made/needed: None

https://hg.mozilla.org/mozilla-central/rev/4a0e3d110258

Comment on attachment 9160079 [details]
Bug 1648417 - Fix the doorhanger icon for updating an autofilled form r?MattN

Approved for 79.0b2. Do we want to nominate this for ESR78 too?

https://hg.mozilla.org/releases/mozilla-beta/rev/fc865ff882f1

Comment on attachment 9160079 [details]
Bug 1648417 - Fix the doorhanger icon for updating an autofilled form r?MattN

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Trivial patch for a user-visible regression
• User impact if declined: An icon won't be shown in the address autofill save doorhanger. This feature is only enabled for en-US users in the US with US addresses.
• Fix Landed on Version: 79,80
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple mismatch/typo fix in a .svg file
• String or UUID changes made by this patch: None

Verified with 79.0b2 and 80.0a1 (2020-06-30) on the mentioned platforms.
Will update the status for the bug once the ESR branch is verified as well.

Comment on attachment 9160079 [details]
Bug 1648417 - Fix the doorhanger icon for updating an autofilled form r?MattN

Approved for 78.1esr.

https://hg.mozilla.org/releases/mozilla-esr78/rev/7276774749c2

Verified with 78.2.0esr on Windows 10, macOS 10.15.