Open Bug 1645368 Opened 4 years ago Updated 4 years ago

Request Blocking - suppress Toggle for details pane until mouse click-release when trying to Drag and block

Categories

(DevTools :: Netmonitor, enhancement, P3)

enhancement

Tracking

(firefox78 affected, firefox79 affected)

Tracking Status
firefox78 --- affected
firefox79 --- affected

People

(Reporter: cfogel, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Notes:

  • when trying to drag-and-drop a request to block it the Request Details section is displayed on mouse click-down instead of click-release;
    The problem is when the browser size/width causes the Details section to overlap the requests thus making the Drag-to-Block scenario harder;
  • as Harald/Kriyszig iterated in bug 1596091, there would be some benefits; but the main issue would be with the panels adjusted for decreased available space;

Affected versions

  • 78.0b6, 79.0a1

Affected platforms

  • macOS 10.15.5, Ubuntu 20, Windows 10

Steps to reproduce

  1. Launch Firefox, enable DevTools and access any webpage;
  2. Enable the Request blocking tab;
  3. Click on any network request from the list;
  4. Grab the browser and shrink width until the [Request Details] section is collapsed;
  5. Click on the [Hide Request Details] button;
  6. Click and hold over any request from the list;
  7. Try to drag and drop it in the Blocking section;

Enhancement suggestion

  • Request details section is not displayed;

Actual result

  • Request Details section is displayed covering up the requests list;

Regression range

  • not a regression, visible after implementation for bug 1596091

Additional notes

  • attached recording with what's the problematic scenario

I see. During my testing I used three windows side by side so I didn't run into this problem
I noticed this happens for aggressively small (in terms of height) window with 3 panes open.

Indeed hiding network details panel on DragStart event seems like a good solution because Click is almost always, if notalways fired before a DragStart event.

@Honza how do you think we should approach this problem?

Flags: needinfo?(odvarko)
Has STR: --- → yes
Severity: -- → S3
Priority: -- → P2

(In reply to Kriyszig from comment #1)

Indeed hiding network details panel on DragStart event seems like a good solution because Click is almost always, if notalways fired before a DragStart event.

@Honza how do you think we should approach this problem?

I agree that hiding the Details panel is probably the best we can do.
Thanks for pointing that out!

Honza

Flags: needinfo?(odvarko)
Priority: P2 → P3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: