[mediaqueries-5] Remove prefers-color-scheme: no-preference.
Categories
(Core :: CSS Parsing and Computation, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox79 | --- | fixed |
People
(Reporter: mozilla-apprentice, Assigned: emilio)
References
Details
(Keywords: dev-doc-complete, site-compat)
Attachments
(2 files)
Resolutions were made for csswg-drafts/#3857.
[mediaqueries-5] UA guidance on light vs no-preference
- RESOLVED: Remove the no-preference value
- RESOLVED: Add a note that no-preference used to exist but was removed due to lack of impl
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
It was removed from the spec. Bug 1643934 updates the WPT tests.
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bca9f7459a16 Remove prefers-color-scheme: no-preference. r=gl,remote-protocol-reviewers,hiro,whimboo
|
||
Updated•4 years ago
|
|
||
Comment 3•4 years ago
|
||
Though probably not blocked by this bug, https://bugzilla.mozilla.org/show_bug.cgi?id=1642366 removes the no-preference value from devtools as well.
|
||
Comment 4•4 years ago
|
||
Backed out for perma failures.
Logs:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305638657&repo=autoland&lineNumber=6101
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305644716&repo=autoland&lineNumber=4675
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305638095&repo=autoland&lineNumber=6079
Backout: https://hg.mozilla.org/integration/autoland/rev/089af72b96ed33cccd1e6d761ce932de1d3ddc76
|
|
Assignee | |
Comment 6•4 years ago
|
||
So as to not use a pref with an invalid value, which I would've changed
the behavior of with the previous patch.
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/245776c0b467 Fix GeckoRuntimeSettings color scheme configuration. r=geckoview-reviewers,snorp
|
|
Assignee | |
Comment 8•4 years ago
|
||
I'll land the second patch. The first one still needs bug 1643934 to land. I saw an wpt-sync fly by and I didn't realize that wasn't part of it.
|
||
Comment 9•4 years ago
|
||
| bugherder | ||
|
||
Comment 10•4 years ago
|
||
Emilio: prefers-color-scheme is broken in Fenix (https://github.com/mozilla-mobile/fenix/issues/11556).
Working: AC 45.0.20200610130052 with GV 79.0a1-20200609092134
Not working: AC 45.0.20200612130101 with GV 79.0a1-20200611093454
And your patch landed between these two versions. Could it be that your patch caused the problem?
|
|
Assignee | |
Comment 11•4 years ago
|
||
It seems possible, can you point me to how is A-C using GeckoRuntimeSettings?
|
|
||
Comment 12•4 years ago
|
||
But I don't really know the implementation. So maybe better ask one of the developers. 😅
|
|
||
Updated•4 years ago
|
|
||
Comment 13•4 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/52126fd9ffdf Remove prefers-color-scheme: no-preference. r=gl,remote-protocol-reviewers,hiro,whimboo
|
||
Comment 14•4 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 15•4 years ago
|
||
(In reply to Sören Hentzschel from comment #12)
But I don't really know the implementation. So maybe better ask one of the developers. 😅
I took a look this morning, bug 1645770 fixes it.
|
|
||
Comment 16•4 years ago
|
||
Posted a site compatibility note for the change.
|
||
Comment 17•4 years ago
|
||
I've documented this removal; see https://github.com/mdn/sprints/issues/3424#issuecomment-652649191 for the full details.
Description
•