Debugger should show TypeScript icon for .TSX files
Categories
(DevTools :: Debugger, enhancement, P3)
Tracking
(firefox81 fixed)
| Tracking | Status | |
|---|---|---|
| firefox81 | --- | fixed |
People
(Reporter: Harald, Assigned: varundey20, Mentored)
Details
(Keywords: dev-doc-needed, good-first-bug)
Attachments
(3 files)
image.png
STR:
- Open Debugger on https://excalidraw.com/
/static/js/components/contains a few TSX files
AR: Generic icon
ER: TypeScript or React icon
|
||
Comment 1•4 years ago
|
||
Hey Harald,
can I work on this one? I fixed a similar bug for vue files, so I guess it will be similar (though I worked on it two years ago, so I have to setup everything first).
|
Reporter | |
Comment 2•4 years ago
|
||
Thank you, Dennis, it's all yours. Please reach out in our Debugger channels or here if you need any help.
|
||
Comment 3•4 years ago
|
||
The severity field is not set for this bug.
:jlast, could you have a look please?
For more information, please visit auto_nag documentation.
|
Assignee | |
Comment 4•4 years ago
|
||
Hey Herald. This seems inactive. Can I take this up?
|
|
Reporter | |
Comment 5•4 years ago
|
||
(Taking you off Dennis, but thank you for offering to help)
Varun, it's yours – thank you! David can help with guidance if needed.
|
|
Assignee | |
Comment 6•4 years ago
|
||
Hi David, can you help me where to get started with this? Tried reaching out to you on element as well.
|
||
Comment 7•4 years ago
|
||
Hello Varun! I recommend looking in the following file:
This component dictates source icons, so I recommend exploring the information provided by the source to see how we can determine typescript :)
|
|
Assignee | |
Comment 8•4 years ago
|
||
Depends on D84896
|
|
Assignee | |
Comment 9•4 years ago
|
||
I noticed a weird thing here. On clicking the .tsx file, it shows a React icon. Though I have raised a PR for the original issue, this seems to be a separate bug since same thing happens even after we show TS icon for .tsx file type
|
||
Comment 10•4 years ago
|
||
Pushed by dwalsh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d40578774887 Show TypeScript icon for .tsx extension. r=davidwalsh
|
||
Comment 11•4 years ago
|
||
| bugherder | ||
|
||
Updated•4 years ago
|
Description
•