Date information are shown in about:logins page for RTL builds only after the page is refreshed
Categories
(Firefox :: about:logins, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox-esr78 | --- | fix-optional |
firefox75 | --- | unaffected |
firefox76 | --- | wontfix |
firefox77 | --- | wontfix |
firefox78 | --- | wontfix |
firefox79 | --- | fix-optional |
People
(Reporter: asoncutean, Unassigned)
Details
(Keywords: regression)
Attachments
(1 file)
3.39 KB,
image/png
|
Details |
Affected versions
- 77.0a1
- 76.0
Affected platforms
- Windows 10
- macOS 10.15
- Ubuntu 18.04
Steps to reproduce
- Open a RTL Firefox build (eg. ar)
- Save credentials for any website (eg. https://www.facebook.com/)
- Open the about:logins page
- Observe the تاريخ الإنشاء (Created) / آخر تعديل (Last modified) / آخر استخدام (Last used) fields
Expected result
- The date of the corresponding action is displayed for every section
Actual result
- “???” is shown instead of dates
Regression range
- I ran a regression manually with the following result:
Additional notes
- The dates are shown after the about:loggins page is refreshed once
- Reproducible on he locale (RTL build as well)
- Not reproducible on en-US, de, zh-CN
Reporter | ||
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Comment 1•4 years ago
|
||
m_kato, could you prioritize this one? Also do you think this should be tracked for a dot release?
Comment 2•4 years ago
|
||
Possibly regressed by bug 1622042?
Updated•4 years ago
|
Comment 3•4 years ago
|
||
Zibi, known issue? Could you handle this?
Updated•4 years ago
|
Comment 4•4 years ago
|
||
I looked into it, and found two-layer issue:
This code fallbacks are wrong. They use ""
as a fallback, but since this is used as epoch
it should be a number.
- With (1) fixed, the values of
this._timeCreated
|this._timeUsed
|this._timeChanged
is falsy inar
but not inpl
oren-US
I'm not sure what causes the difference, it may be a race condition maybe? But it seems like some timing bug since I don't believe this code should be called with falsy values.
It also explains why after reload it looks good (since the values are not falsy anymore).
I'm tentatively reassigning it to about:logins
component because while the bug is visible depending on locale, it seems like the solution requires understanding why those variables are falsy
.
I also couldn't reproduce it in pseudolocalization, so my first hypothesis is that since ar
is incomplete, we load two locales, which takes a bit more time, and somehow in that scenario those variables are falsy.
If we end up finding out that some Intl code is causing them to be falsy, it may be moved back to Core::Internationalization
.
NI on Jared, since he wrong those lines.
Updated•4 years ago
|
Comment 5•4 years ago
|
||
What's the status for this bug wrt our upcoming releases? Thanks
Comment 6•4 years ago
|
||
S1 or S2 bugs need an assignee - could you find someone for this bug?
Comment 7•4 years ago
|
||
This is on Jared. See comment 4.
Comment 8•4 years ago
|
||
I question putting this at S1 or S2. The metadata is not critical functionality and a workaround does exist.
Updated•4 years ago
|
Comment hidden (abuse-reviewed) |
Comment 10•2 years ago
|
||
Moving to P3 as this is not happening in the next release cycle.
Reporter | ||
Comment 11•2 years ago
|
||
I can no longer reproduce this issue with the latest RTL - ar Nightly (103.0a1->2022-06-21) on Windows 10 and MacOS 11.0.
Description
•