Closed Bug 1632203 Opened 4 years ago Closed 4 years ago

Installer progress bar is not visible with high contrast mode enabled

Categories

(Firefox :: Installer, defect, P2)

77 Branch
Desktop
Windows 10
defect

Tracking

()

VERIFIED FIXED
Firefox 77
Tracking Status
firefox-esr68 --- unaffected
firefox75 --- unaffected
firefox76 --- unaffected
firefox77 --- verified

People

(Reporter: dcicas, Assigned: agashlin)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(3 files)

Note

  • note1

Affected versions

  • Fx 77.0a1

Affected platforms

  • Win 10

Steps to reproduce

  1. Activate high contrast mode.
  2. Download and run the stub installer.

Expected result

  • The progress bar is visible.

Actual result

  • The progress bar is invisible.

Regression range
Fx 77.0a1 (build ID 2020-04-21-09-42-20)

Blocks: 1632191
Has Regression Range: --- → yes
Has STR: --- → yes
Assignee: nobody → agashlin
Priority: -- → P2

It looks like the method we're using to display the progress bar, which relies on contrasting background-colors, is not going to work with high contrast, which overrides colors. I'll look into alternatives.

These styles will produce no change in the layout, and only apply in
high contrast mode.
Also removed an extra comma that broke parsing in aurora.

Here's what the patch looks like. There is a little artifact due to Windows blitting the outline and border both with XOR, so when they overlap the color switches back, and there are little single-pixel lines of this due to my high DPI display, but I think it is acceptably legible.

Pushed by agashlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/954ee70d2de7
Show legible progress bar in high contrast mode. r=mhowell
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 77

Tested on the latest Fx77.0a1 on Windows 10.
The install bar is now visible while using the high contrast theme, both black and white options. The issue is verified fixed.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: