Closed
Bug 1632132
Opened 4 years ago
Closed 4 years ago
Dark theme - screen reader - previous/next buttons appear disabled due to color scheme picked
Categories
(Toolkit :: Reader Mode, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla77
People
(Reporter: cfogel, Assigned: mconley)
Details
(Keywords: regression)
Attachments
(2 files)
Screenshot 0002-04-22 at 15.51.39.png
Affected versions
- 76.0b7, 77.0a1(2020.04.20)
Affected platforms
- Windows 10, macOS 10.15.3, Ubuntu 18.04;
Steps to reproduce
- Launch Firefox and access https://longform.org/best
- Click on the button to trigger the reader mode;
- Change the theme for it on Black/Dark;
- Click on the Narrate button click on the play button;
- Click on Play to start narration;
- Click on the Next/Previous button;
Expected result
- buttons appear as being available;
Actual result
- due to color setup next/previous buttons appear as being unavailable;
Regression range
- will check and provide one asap;
Additional notes
- attached recording to better illustrate the issue;
- ideally color would be changed to white as well for the 2 buttons, at least once available.
|
Reporter | |
Updated•4 years ago
|
Has Regression Range: --- → yes
Has STR: --- → yes
|
|
Reporter | |
Comment 1•4 years ago
|
||
Recording for it.
|
||
Updated•4 years ago
|
Has Regression Range: yes → no
|
||
Comment 2•4 years ago
|
||
Initially tested the issues on Windows 10 x64 with Firefox 75.0. Updating the status flag as well.
- Regression range:
- Last good: 2019-04-22
- First bad: 2019-04-23
- Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4c7eaf384b06cfda8314be34cd179ab46f271ccc&tochange=4b0811d7b8e1591d4e48a26bdb8666a1bc5ccf61
- Possible regressor: https://bugzilla.mozilla.org/show_bug.cgi?id=1187696
status-firefox75:
--- → affected
|
|
Reporter | |
Comment 3•4 years ago
|
||
Thanks for the updates @Julien & abodenlosz.
Has Regression Range: no → yes
Keywords: regressionwindow-wanted
|
|
||
Updated•4 years ago
|
status-firefox-esr68:
--- → wontfix
Version: Trunk → 68 Branch
|
Assignee | |
Comment 4•4 years ago
|
||
I suspect this is because these rules:
are overriding this rule:
The hardcoded values in narrate.css don't seem to be compatible with the dark theme, so it probably makes sense to fallback to using the values defined in aboutReader.css, which automatically adjust between dark and light theme.
Assignee: nobody → mconley
Priority: -- → P1
|
|
Assignee | |
Comment 5•4 years ago
|
||
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/88fd740ab35c Fix about:reader narrate back and forward buttons for dark theme. r=ntim
|
||
Comment 7•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
|
|
||
Comment 8•4 years ago
|
||
Verified the fix with Nightly 77.0a1 (2020-04-26) on Windows 10 x64. Updating the flag to verified.
|
|
||
Comment 9•4 years ago
|
||
Also verified on macOS 10.15 and Ubuntu 18.04 x64 with the latest Nightly build.
You need to log in
before you can comment on or make changes to this bug.
Description
•