Closed Bug 1629483 Opened 4 years ago Closed 4 years ago

Highlight tile separator lines with opacity overlap

Categories

(Firefox :: New Tab Page, defect, P2)

defect

Tracking

()

VERIFIED FIXED
81 Branch
Tracking Status
firefox75 --- wontfix
firefox76 --- wontfix
firefox77 --- wontfix
firefox81 --- verified

People

(Reporter: cfogel, Assigned: thecount)

Details

Attachments

(4 files)

Affected versions

  • 75.0, 76.0b4, 77.0a1 (2020-04-09);

Affected platforms

  • Windows 10, macOS 10.15.3, Ubuntu 18.04;

Steps to reproduce

  1. Launch Firefox;
  2. (optional) navigate random pages until highlights section is populated with at least 1 site;
  3. Zoom over the highlight tile and hover over it;

Expected result

  • elements are displayed properly;

Actual result

  • separators for highlight icon overlap, the opacity is affected causing dots of harder colour intensity;

Enhancement suggestion

  • cut separator lines before they reach the circle so they won't overlap anymore;

Regression range

  • will check and provide one if needed;
  • at first glimpse checking with older builds such as 62.0.3 shows the same design so inclined to say it's not one;

Additional notes

  • attached screenshot with the issue.
Priority: -- → P2
Has Regression Range: --- → no
Has STR: --- → yes

I'm not sure what you mean by separators, but I can confirm the dots are much darker in a light theme for a card than they are for a section, is that the issue?

Yes, where the line+halfCircle+line join, due to their opacity they show the dots.
Referring to the separator as the line in between the tile image and description section.

While in a light theme the merge dots are darker, on dark theme they are whiter; so it is not limited to a theme.

Applying the opacity over the whole line, not over each individual element(line+halfCircle+line) might fix the issue or offset the lines by 1pixel so they don't overlap anymore should do the trick.

Assignee: nobody → sdowne
Status: NEW → ASSIGNED

I've got a small fix for this.

I moved it by 1 px to clear the overlap.

I also noticed it was using some const size based variables that while were the right number, suggests it was the wrong variable. It was using a size for the icon, not the actual circle size, for placement of the circle. The icon size just so happened to be half the size of the circle, which is right, but that's just by chance. I fixed it so it's now half the size of the circle size, which is probably what we want.

Attached image bad.png
Attached image good+.png

Added images with before and after.

Pushed by sdowne@getpocket.com:
https://hg.mozilla.org/integration/autoland/rev/a0955b50d542
Newtab card opacity lines overlap fix r=gvn
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch

Verified with 81.0a1 (2020-08-03) on the mentioned OSs.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: