Closed Bug 1626414 Opened 4 years ago Closed 2 years ago

SRD() followed by addTrack() exposes mid prematurely

Categories

(Core :: WebRTC, defect, P2)

defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox-esr68 --- unaffected
firefox74 --- unaffected
firefox75 - wontfix
firefox76 - wontfix
firefox77 --- wontfix

People

(Reporter: jib, Unassigned)

References

(Regression)

Details

(Keywords: regression)

STRs:

  1. Open https://codepen.io/henbos/pen/dyorzjV?editors=0012 and share microphone

Expected result:

  • "- addTrack()'s transceiver's mid: null"

Actual result:

  • "- addTrack()'s transceiver's mid: '0'"

Regression range:

8:16.19 INFO: Narrowed inbound regression window from [dd067bf8, 183a3765] (3 builds) to [dd067bf8, 61ca258c] (2 builds) (~1 steps left)
8:16.19 INFO: No more inbound revisions, bisection finished.
8:16.19 INFO: Last good revision: dd067bf8dec86029202bdef6ea7ab9bc36687f49
8:16.19 INFO: First bad revision: 61ca258cdbbfc126019450087db4c97b1c27d2f3
8:16.19 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=dd067bf8dec86029202bdef6ea7ab9bc36687f49&tochange=61ca258cdbbfc126019450087db4c97b1c27d2f3

Flags: needinfo?(docfaraday)

[Tracking Requested - why for this release]: Minor behavioral regression in edge case.

Updated STRs show mid set correctly in 74, but incorrectly in 75 & Chrome https://github.com/w3c/webrtc-pc/pull/2504#issuecomment-607087799

Actually, not tracking since this is a minor regression. Happy to take a fix in 76, though.

Flags: needinfo?(docfaraday)
Priority: -- → P3

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3 (Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3 (normal.)

Severity: normal → S3
Has Regression Range: --- → yes

While researching how to fix bug 1769802, I discovered the cause of this bug. Essentially, we have a collection of bugs where modifications caused by sRD are applied before sRD resolves. This can open opportunities for things like addTrack to attach to transceivers created by sRD, before sRD even resolves. Fixing this is going to be the first step towards fixing bug 1769802.

Blocks: 1769802
Severity: S3 → S2
Priority: P3 → P2

Actually, this particular bug seems to have been fixed already. Other similar bugs remain, however.

(In reply to Byron Campen [:bwc] from comment #6)

Actually, this particular bug seems to have been fixed already. Other similar bugs remain, however.

Can we close this bug then?

Flags: needinfo?(docfaraday)
Summary: SRD() followed by addTrack() exposes mid prematurely (regression) → SRD() followed by addTrack() exposes mid prematurely

Yeah, that's reasonable.

Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(docfaraday)
Resolution: --- → FIXED
Resolution: FIXED → WORKSFORME
You need to log in before you can comment on or make changes to this bug.