Broken tooltips on WS payload in Messages panel
Categories
(DevTools :: Netmonitor, defect, P3)
Tracking
(firefox-esr68 unaffected, firefox74 unaffected, firefox75 wontfix, firefox76 fixed, firefox77 fixed)
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox74 | --- | unaffected |
| firefox75 | --- | wontfix |
| firefox76 | --- | fixed |
| firefox77 | --- | fixed |
People
(Reporter: asoncutean, Assigned: kartikc.918)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: good-first-bug, regression)
Attachments
(2 files)
|
9.93 KB,
image/png
|
Details | |
|
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
screenshot issue.png
- Follow up from bug 1591908
Affected versions
- 76.0a1 (2020-03-30)
- 75.0b11
- 74.0
Affected platforms
- Windows 10
- Ubuntu 18.04
Steps to reproduce
- Load https://socket.io/
- Select the Network panel and reload the page
- Set the WS filter button in the Toolbar to make it easier to find 101 requests
- Select the 101 request and look at the Messages panel
- Wait for a frame with bigger payload body
- Hover over the raw in the WS frame list
Expected result
- The tooltip is not broken
Actual result
- The tooltip is broken
Regression range
- Not a regression, tooltip is broken in Messages panel from the start
Additional notes
- Note that after the initial fix, most of the tooltips end with ellipsis
- Also some characters are broken inside the tooltip (see the attached screenshot)
|
||
Comment 1•4 years ago
|
||
Thanks for the report!
I can reproduce on my machine (Win10, Nightly).
@Vitalii: you were working on the original patch. Could you please look at this follow up?
Honza
|
|
||
Updated•4 years ago
|
I'd like to take this up.
Could you provide more information about this bug @Honza ? Thanks.
|
|
||
Comment 3•4 years ago
|
||
Assigned to you, thanks for the help!
Honza
|
|
||
Updated•4 years ago
|
|
||
Comment 4•4 years ago
|
||
Bugbug thinks this bug is a regression, but please revert this change in case of error.
Pushed by jodvarko@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/95e289208001 Broken tooltips on WS payload in Messages panel r=Honza
|
||
Comment 7•4 years ago
|
||
| bugherder | ||
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
|
||
Comment 8•4 years ago
|
||
Comment on attachment 9140017 [details]
Bug 1626189 - Broken tooltips on WS payload in Messages panel r?honza
Beta/Release Uplift Approval Request
- User impact if declined: Only impact web developers dealing with web sockets.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Low risk, just one liner patch related to a tooltip size limit.
- String changes made/needed:
|
|
||
Comment 9•4 years ago
|
||
Comment on attachment 9140017 [details]
Bug 1626189 - Broken tooltips on WS payload in Messages panel r?honza
Minor devtools fix. Approved for 76.0b6.
|
|
||
Comment 10•4 years ago
|
||
| bugherder uplift | ||
Description
•