Closed Bug 1624608 Opened 4 years ago Closed 4 years ago

Drop down searched strings are no longer highlighted after following certain steps

Categories

(Firefox :: Settings UI, defect, P1)

Product:
Firefox
Component:
Settings UI
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 76
Tracking Flags:
Tracking Status
firefox-esr68 --- wontfix
firefox74 --- wontfix
firefox75 --- wontfix
firefox76 --- verified

People

(Reporter: atrif, Assigned: bgrins)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

highlight_0.gif
995.51 KB, image/gif
Details
Bug 1624608 - Fix highlightable menuitems in preferences by including them in searchWithinNode
47 bytes, text/x-phabricator-request
Details | Review
Attached image highlight_0.gif —

Affected versions

  • 76.0a1 (20200323092419)
  • 75.0b7 (20200322132212)
  • 74.0 (20200309095159)

Affected platforms

  • Windows 10 x64
  • Ubuntu 18.04
  • macOS 10.15

Steps to reproduce

  1. Open Firefox and go to about:preferences#home.
  2. Click on “New tabs” dropdown and select “Blank Page”
  3. Search for firefox in Find in Option.
  4. Click again on “New tabs” dropdown and observe the Firefox Home string.

Expected result

  • Firefox string is highlighted.

Actual result

  • Firefox string is not highlighted.

Regression Range

Notes

  • Attached a screen recording with the issue.
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox74: affected → wontfix
status-firefox75: affected → fix-optional
Component: XUL Widgets → Preferences
Product: Toolkit → Firefox
Flags: needinfo?(bgrinstead)

This fixes the reported issue but I haven't yet checked to see if it causes any other problems,
or if/why this was removed in the first place.

OK, I think what's happening is that in a XBL world we hit nodeObject.childElementCount == 0 at https://searchfox.org/mozilla-central/rev/8526066f548af9ec3ebb462ff73c47ccc183f533/browser/components/preferences/in-content/findInPage.js#374. But with our current CE implementation we aren't using Shadow DOM so we do have child nodes. This was worked around for buttons when they were converted to CE in https://hg.mozilla.org/mozilla-central/rev/936c2d201405#l3.12 using the same thing my patch in Comment 2 does.

Flags: needinfo?(bgrinstead)
Attachment #9136380 - Attachment description: Bug 1624608 - WIP Include menuitems in searchWithinNode in preferences → Bug 1624608 - Fix highlightable menuitems in preferences by including them in searchWithinNode
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Priority: -- → P1
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/43d5a2bbdd36
Fix highlightable menuitems in preferences by including them in searchWithinNode r=jaws

https://hg.mozilla.org/mozilla-central/rev/43d5a2bbdd36

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox76: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 76

Verified with Firefox 76.0a1 (20200330220101) on Windows 10x64, macOS 10.12 and Ubuntu 18.04.

Status: RESOLVED → VERIFIED
status-firefox76: fixed → verified
Regressions: 1643626
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: