Open Bug 1624590 Opened 4 years ago Updated 4 years ago

[macOS] - Search checkboxes in about:preferences page is truncated on shrinking browser

Categories

(Firefox :: Settings UI, defect, P3)

Unspecified
macOS
defect

Tracking

()

Tracking Status
firefox-esr68 --- wontfix
firefox74 --- wontfix
firefox75 --- wontfix
firefox76 --- fix-optional

People

(Reporter: cfogel, Unassigned)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Affected versions

  • 75.0b7, 76.0a1 (2020-03-22)

Affected platforms

  • macOS 10.15

Steps to reproduce

  1. Launch Firefox, access about:preferences#search
  2. Resize width until text from sections is no longer displayed;
  3. Click on the SearchBar buttons for any of the options;

Expected result

  • no issues occur;

Actual result

  • on-click effect is truncated (circle not complete);
  • as page is resized top circle gets truncated as well;

Regression range

  • will provide one asap;

Additional notes

  • attached screenshot with the issue.
Has Regression Range: --- → no
Has STR: --- → yes

(In reply to Oana Botisan, Desktop Release QA from comment #1)

Regression range

This autoland pushlog is wrong. The correct m-c window is https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2872e7a3606d6108874930a1eb4062c74bad0e9e&tochange=c9f6d6242851d25e230bc6a81fb45bfc8f93e6c1 and this (probably) regressed with bug 1493844.

(In reply to Cristian Fogel, QA [:cfogel] from comment #0)

Actual result

  • on-click effect is truncated (circle not complete);

This is because the focus ring uses an outline with an offset, and there's no margin/padding into which that offset can expand (that isn't overlapped by the sidebar) so it ends up being cut off.

  • as page is resized top circle gets truncated as well;

I don't really understand what this means. Can you create a screencast to show what you mean? It looks to me like the page is just scrolled down, but maybe you mean something else?

Flags: needinfo?(cristian.fogel)
Regressed by: 1493844

(In reply to :Gijs (he/him) from comment #2)

I don't really understand what this means. Can you create a screencast to show what you mean? It looks to me like the page is just scrolled down, but maybe you mean something else?

You are right on that part, page most likely was scrolled down.
No recording needed.

Flags: needinfo?(cristian.fogel)

The padding here needs to be increased to 3px (can probably just do it for the start side based on the directionality of the text). However, the General and Privacy sections will start to show a horizontal scrollbar (in en-US) because of the indented checkbox in Nightly Data Collection and Use and the hbox in the Network Settings section. This problem probably already exists for languages like German and isn't just limited to those two places.

Ideally the fix for this bug would be to increase the padding where necessary and also wrap the checkbox labels and descriptions.

Priority: -- → P3

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3 (Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3 (normal.)

Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.