Closed Bug 1624311 Opened 4 years ago Closed 3 years ago

Notifications - Change [Learn more] selection spans across the whole row instead of just the text

Categories

(Toolkit Graveyard :: Notifications and Alerts, defect, P5)

Tracking

(firefox75 wontfix, firefox76 wontfix, firefox85 wontfix, firefox86 wontfix, firefox94 verified)

VERIFIED FIXED
94 Branch
Tracking Status
firefox75 --- wontfix
firefox76 --- wontfix
firefox85 --- wontfix
firefox86 --- wontfix
firefox94 --- verified

People

(Reporter: cfogel, Assigned: itiel_yn8)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Affected versions

  • 75.0b7, 76.0a1 (2020-03-23);

Affected platforms

  • macOS 10.15, Ubuntu 18.04, Windows 10;

Steps to reproduce
Preconditions: might be irrelevant but for the test:
Dom.security.featurepolicy.enabled -- set to true;
permissions.delegation.enabled -- set to true;

  1. Launch Firefox and access: https://joo.crater.uberspace.de/frame-permissions.html
  2. Click on the message icon in the address bar;

Expected result

  • popup and contained elements are properly displayed;

Actual result

  • selection for Learn more spans across the whole row;

Enhancement suggestion

  • selection is limited to the length of the text;

Regression range

  • will check if one asap;

Additional notes

  • attached screenshot with the issue.
Type: enhancement → defect

Johann, have we made recent changes here? Either way, can you assign a priority since it affects more of your prompts.

Flags: needinfo?(jhofmann)

I feel like this is a dupe, and it has always been like that (see bug 1416373 which was filed two years ago).

Considering that we've lived with this for so long it's a P5 for me.

Flags: needinfo?(jhofmann)
Priority: -- → P5

This is not a regression. I can reproduce the issue on Nightly from 2015-10-06 when the "Learn more" link was first introduced inside the prompt.

Has STR: --- → yes

Same scenario for the Form autofill prompt.

Updating for 85.0b6, was 86.0a1(2020-01-06).

Severity: normal → S4
Summary: Notifications - Change [Learn more] selection spans acdross the whole row instead of just the text → Notifications - Change [Learn more] selection spans across the whole row instead of just the text
Version: unspecified → Trunk
Assignee: nobody → itiel_yn8
Status: NEW → ASSIGNED
Blocks: 1416373
Pushed by itiel_yn8@walla.com:
https://hg.mozilla.org/integration/autoland/rev/6f59ddd28504
Don't span "Learn more" text across the whole row in notification popups r=desktop-theme-reviewers,dao
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
Blocks: 1706534
Flags: qe-verify+

Verified with 94.0b2 on https://www.cnet.com/

Status: RESOLVED → VERIFIED
See Also: → 1737649
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.