Closed Bug 1623310 Opened 4 years ago Closed 4 years ago

About addons - right click on menu button shows context menu

Categories

(Toolkit :: Add-ons Manager, defect, P3)

defect

Tracking

()

VERIFIED FIXED
mozilla77
Tracking Status
firefox-esr68 --- unaffected
firefox74 --- wontfix
firefox75 --- wontfix
firefox76 --- wontfix
firefox77 --- verified

People

(Reporter: cfogel, Assigned: mstriemer)

References

Details

(Keywords: regression)

Attachments

(2 files)

Affected versions

  • 75.0b5, 76.0a1 (2020-03-18)

Affected platforms

  • Windows 10, macOS 10.15, Ubutnu 18.04;

Steps to reproduce

  1. Launch Firefox, access about:addons
  2. Click on the extensions section;
  3. Instal any addon if not already;
  4. Click on the [...] button for the installed addon;
  5. Right Click on any option from the context menu --- anywhere except the text/icon);

Expected result

  • nothing happens;

Actual result

  • context menu displayed;

Regression range

Additional notes

  • attached screenshot with the issue.
Has Regression Range: --- → no
Has STR: --- → yes

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Keywords: regression

Updating the initial report with the regression range found.
Apparently, when the design change for the section this scenario might have been overlooked since with the old layout the whole div containing information about the addon provided with menu options for it.

Has Regression Range: no → yes
Assignee: nobody → mstriemer
Status: NEW → ASSIGNED

There is already a patch, but can you please set a priority, too? Thanks!

Flags: needinfo?(mstriemer)
Flags: needinfo?(mstriemer)
Priority: -- → P3
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/41485ce7600f
Only open about:addons menus on primary mouse button r=rpl
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77

The patch landed in nightly and beta is affected.
:mstriemer, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(mstriemer)

I don't think this is worth uplifting. Also noticing now that the bug was about the items in the menu rather than the button to open the menu, so this isn't actually fixed.

Flags: needinfo?(mstriemer)
Blocks: 1629573
Summary: About addons - right click on list item from context menu on addon settings shows context menu → About addons - right click on menu button shows context menu
Flags: qe-verify+

Something is odd, as the issue still reproduces with both mouse/touchpad controls.
@Mark, mind taking a second look at this?

Flags: needinfo?(mstriemer)

I had misinterpreted the bug initially. What I'm seeing on Windows now is what I'd expect.

We don't hide the context menu anywhere else (intentionally) so I think right clicking should open the context menu. The change that was made in this bug was so that right clicking on the [...] button will open the context menu, but not the more options menu that opens on a left click. Right clicking on menu items should open the context menu, but it doesn't open on the text since that's a xul:label which disables the context menu. This is expected and when the xul:label gets ported to HTML it should show the context menu (bug 1602095).

Flags: needinfo?(mstriemer)

I see, can close this one then from my side as well in that case.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.