Affected versions

• Fx 75.0b3
• Fx 76.0a1

Affected platforms

• Windows 10 x64
• Windows 8.1 x64
• Ubuntu 18.04 x64
• macOS 10.13

Steps to reproduce

1. Launch Firefox, use a dirty profile with reasonable amount of browsing history.
2. Select the History option from the View History, saved bookmarks and more Menu.
3. Click on the Show All History menu item.
4. Select 2 or more websites pressing CTRL from keyboard.
5. Right click on selected items to open context menu.
6. Click on Bookmark Pages.

Expected result

• The selected websites bookmarked.

Actual result

• Nothing happened, the selected pages are not bookmarked.

Regression range

• I will come back with regression range ASAP.

Additional Notes

• The selected websites are bookmarked if you insert some tags.

So this basically means adding multiple bookmarks from an history view is broken. I don't see errors reported to the console.

Mark, do you have any spare time to investigate this?

I've taken a quick look, and I can see that this._view.selectedNode is null when there's more than one selected node:

https://searchfox.org/mozilla-central/rev/3f8c67d7fd836d559491e3fe497bc739f707c1a6/browser/components/places/content/controller.js#207

The strange thing is, this was added back in bug 422181 in Firefox 3.6... and that code hasn't changed since then.

Timea, do you have a regression range yet? I think that might help here.

Hi, I tested this issue on builds from Fx 48.0 to Fx 75.0b6 and it seems this is not a regression, reproduced on every build. I will attache a screenshot.

https://hg.mozilla.org/mozilla-central/rev/71de2075e13e

The patch landed in nightly and beta is affected.
:standard8, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

This can ride the trains.

I can confirm this issue is fixed, I verified using Firefox 77.0a1 (latest nightly 2020.05.03) on Win 8.1 x64, macOS 10.15 and Ubuntu 18.04 x64.